-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task matching #20
Task matching #20
Conversation
I don't understand what you mean by this.
Only closed as completed issues. This proves that they were able to accomplish the task.
I don't understand. No webhooks are applicable here. You use GraphQL to search all the "closed as complete" issues that are assigned to the contributor. |
If some is assigned an issue that particular issue's payload is updated. This could be rewritten with graphql instead.
Shouldn't it be a query with similar issues and who completed them. Instead of querying with all users. So, when issues are completed their payload object will still show as open. To prevent this we could listen for webhooks. |
I'm sorry but I have little context on the "payload object" I haven't worked on any plugins officially. Feel free to ask me clarifications on the spec. Perhaps @gentlementlegen might know what you're talking about |
Updated the comment structure, the comments should start with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test this? The syntax doesn't look correct. Pretty sure all quotes need the space to avoid problems
Its working, you can check the updated comment in the (Old Issue) |
@gentlementlegen can you install this plugin |
@0x4007 Is this plugin supposed to be a worker or an action? According to the readme it should be an action but no deployment script has been added here. Since I was not sure in the meantime I set it as an Actions and I fixed the run crashing here. |
It should be deployed as an worker, but it does work as an action as well. |
Added deployment scripts, last run here, will change to a worker in the configuration. Also fixed default values for the configuration and modified the description in the manifest to remove a reference to |
Another question, I am confused by these logs. Does it mean it is running properly? Error |
@0x4007 I do not see a database set up on Supabase for this. Could you create an instance? I do not have the permissions to do so. |
You can make a separate database. We can clean house another week |
You mean that I should use my own credentials / API keys for this db? |
I upgraded with my own credentials. Heads up that now it seems you're limited to two projects on Supabase. |
I think just make one ubiquity-os project on your Supabase and then make new tables with the names of the plugins I guess. |
This would need a centralized migration file to keep the db up to date. Projects with dbs already have their own migration files so all projects should be merged. |
I prefer figuring out git based storage as a "final" storage solution. Let's make do in a janky way with Supabase for the short term. It would be extremely convenient if the plugin repositories themselves can handle everything: runtime/hosting (GitHub actions) and storage. Maybe some day in the future we can optimize the cold start times (i.e. compile to something that runs natively without node) to use GitHub actions in place of workers. |
If there is an efficient way to store, access, sort and join millions of items based on a git system, this can be replaced. Vector embeddings should have a consequent size quickly. I think in the meantime each project should use their own db when possible. The project seems properly set up although it always fails to create entries, see this run. @sshivaditya2019 Am I doing something wrong? |
The |
So how is an issue created? |
Currently, the expected process is as follows: An issue is created, followed by comments that can be created, edited, or deleted. When an issue is deleted, all associated comments are also removed. |
Its something do with the it being run in GitHub actions. |
@sshivaditya2019 It is currently running within |
I am trying to deploy it on worker right now with the workers script. In the meantime could you please try |
@sshivaditya2019 It is a private repository indeed, I forgot about the redacting of the comments, it makes sense now. I will try with a public repo. |
Maybe we shouldn't redact comments in the near future. And instead have a switch for it later when/if partners ever ask. I feel like most people won't care and it will give us more data to work with for research purposes in the near future. |
@sshivaditya2019 do you think we should make a new task to create a script to populate our database with the issues? We have a ton of old data we can benefit from. |
I guess it would be fine to have it as an option in the configuration, because as long as not everybody can access the DB the content of private repositories cannot be read by outsiders. |
Are we taking about something like a seed file ? That should be easy. Otherwise, I can probably write a python/js script to do that. Either way it would be better to have a separate task/ticket to handle that. |
Issue is that, if by chance the key gets leaked, and orgs private issue threads are leaked as well, it would an serious issue for the plugin maker (Ubiquity) in this case. |
Resolves #7
issue
matching option.issue.labeled
,issues.created
andissues.edited
.