-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update worker-deploy.yml #53
Update worker-deploy.yml #53
Conversation
551544d
into
ubiquity-os-marketplace:development
@Keyrxng I just realized something in these PRs: it won't work to generate the link. Look at an example I tried that would work: |
My implementation works without the need to add the worker name as seen in the QA for the PR that was closed
gentlementlegen/ubiquity-os-kernel#1 (comment) I pull the plugin name from the url of the worker itself within the fetch const workerUrl = new URL(inputs.ref).origin;
let workerName;
if (workerUrl.includes("localhost")) {
workerName = "localhost";
} else {
workerName = `${workerUrl.split("//")[1].split(".")[0]}`;
} Is this what you meant, sorry, I think now maybe I misunderstand what you were pointing out. |
@gentlementlegen the task (ubiquity-os/plugin-sdk#34) was dropped from P3 to P1 which is why I focused on higher priority tasks but I think they have been pretty much more or less cleared or are in the process of. Perhaps the task priority can be re-raised and I'll focus on it again? Also regarding the callback builder PR that was closed, likewise if you could label the task I'd be happy to jump back into SDK work |
If that works to build the URL pointing to the Cloudflare Dashboard then I am fine with it. I just remembered that I had issues building the URL and I thought about it afterwards. |
Yeah that works just fine mate Deploy injects ID, so it's available in the worker env when deployed but not locally but that's impossible anyway so I just name it |
relates to ubiquity-os/plugin-sdk#34