fix: inputs and build #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feat/schema validation
Simplified event whitelist types and transformations for clarity.
Set default values for watch config, renamed project, and added debug log.
Corrected the order of parameters to match expected types.
Removed unnecessary console.log and clarified error messages for invalid events.
Simplified update workflow and adjusted action to a Node.js runtime.
Standardize file naming for better consistency and clarity.
Update the package name to @ubiquity-os/daemon-disqualifier.
Deleted the distribution file from the repository.
Removed unused @vercel/ncc dependency from package.json and yarn.lock.
Added dist to ignore patterns in cspell, knip, and prettierignore configs.
Unused files (1)
Unused dependencies (1)
Unused exports (2)
|
…opment # Conflicts: # dist/index.js
Update log level to debug for better control over log verbosity.
0x4007
reviewed
Oct 14, 2024
Updated environment variable names to camelCase as expected by the deploy plugin.
Improved descriptions for inputs to provide clearer context and usage explanations.
0x4007
reviewed
Oct 14, 2024
There was a problem hiding this comment.
When using type: module ncc includes this as an ESM reminder from what I've seen.
https://github.com/vercel/ncc?tab=readme-ov-file#usage-1
0x4007
reviewed
Oct 14, 2024
| @@ -12,8 +12,9 @@ export async function run(inputs: PluginInputs) { | |||
| payload: inputs.eventPayload, | |||
| config: inputs.settings, | |||
| octokit, | |||
| logger: new Logs("verbose"), | |||
| logger: new Logs("debug"), | |||
There was a problem hiding this comment.
I think we should change the API to be something more like
new Logger({ level: "debug" });As I presume that is what this means.
There was a problem hiding this comment.
Yes although the SDK integrates the logger as well so might now be worth changing there right now, I will try to switch this to the SDK later as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #32
QA: https://github.com/Meniole/user-activity-watcher/actions/runs/11320647090