October Sync #28
Merged
October Sync #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opment chore(development): release 1.0.0
feat: schema validation
0x4007
commented
Oct 8, 2024
0x4007
commented
Oct 8, 2024
| @@ -87,5 +88,6 @@ | |||
| "extends": [ | |||
| "@commitlint/config-conventional" | |||
| ] | |||
| } | |||
| }, | |||
| "packageManager": "[email protected]" | |||
0x4007
commented
Oct 8, 2024
src/types/plugin-inputs.ts
Outdated
Comment on lines
40
to
46
| /** | ||
| * By default all repositories are watched. Use this option to opt-out from watching specific repositories | ||
| * within your organization. The value is an array of repository names. | ||
| */ | ||
| watch: T.Object({ | ||
| optOut: T.Array(T.String()), | ||
| }), |
There was a problem hiding this comment.
Why is this nested? It should only be optOut on the top level. Looks like its an artifact left over (opt in was removed.) b199f3d
0x4007
commented
Oct 8, 2024
| @@ -0,0 +1,85 @@ | |||
| export const STRINGS = { | |||
| UBIQUITY: "ubiquity", | |||
| UBIQUIBOT: "ubiquibot", | |||
There was a problem hiding this comment.
All UbiquiBot references should be removed. a9d7179
Closed
|
@0x4007 Should a task be created for the fixes? |
|
Sure that's fine |
…vity-watcher into ubq-testing-fix-issues
Corrected "intial" to "initial" for better readability.
Merged two schemas into one; updated references in test files.
Removed redundant userActivitySettings variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.