Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to random load balance to >1 server nodes #766

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

oarap
Copy link

@oarap oarap commented Mar 16, 2020

Add option to random load balance to >1 server nodes

Adding possibility to set peerConnectionCount so that a single client
node can do a random load balancing among peerConnectionCount top
nodes using the score calculator and peer heap.

…se yarpc for thrift

Add option to random load balance to >1 server nodes

Adding possibility to set `peerConnectionCount` so that a single client
node can do a random load balancing among `peerConnectionCount` top
nodes using the score calculator and peer heap.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #766 into dev will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #766      +/-   ##
==========================================
- Coverage   88.22%   88.09%   -0.14%     
==========================================
  Files          40       40              
  Lines        4101     4115      +14     
==========================================
+ Hits         3618     3625       +7     
- Misses        367      374       +7     
  Partials      116      116              
Impacted Files Coverage Δ
peer.go 93.77% <100.00%> (-0.42%) ⬇️
mex.go 72.51% <0.00%> (-1.90%) ⬇️
reqres.go 81.19% <0.00%> (-1.71%) ⬇️
outbound.go 85.96% <0.00%> (-1.17%) ⬇️
channel.go 88.46% <0.00%> (-0.28%) ⬇️
relay.go 82.87% <0.00%> (ø)
preinit_connection.go 94.16% <0.00%> (+1.45%) ⬆️
idle_sweep.go 100.00% <0.00%> (+3.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7177385...c42a099. Read the comment docs.

@prashantv
Copy link
Contributor

This looks very similar to #631 -- can we consolidate into a single PR? Ideally into the already existing PR, as it's got some history + comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants