-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal to update generated function names #265
Open
davissuber
wants to merge
4
commits into
uber:main
Choose a base branch
from
davissuber:ds-whats-in-a-name
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+265
−81
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
26 changes: 26 additions & 0 deletions
26
tests/src/main/java/testcases/KT008_funky_names/ChildScope.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
/* | ||
* Copyright (c) 2023 Uber Technologies, Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package testcases.KT008_funky_names | ||
|
||
@motif.Scope | ||
interface ChildScope { | ||
|
||
@motif.Objects | ||
abstract class Objects { | ||
|
||
abstract fun myNull(): Null | ||
} | ||
} |
102 changes: 102 additions & 0 deletions
102
tests/src/main/java/testcases/KT008_funky_names/GRAPH.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,102 @@ | ||
######################################################################## | ||
# # | ||
# This file is auto-generated by running the Motif compiler tests and # | ||
# serves a as validation of graph correctness. IntelliJ plugin tests # | ||
# also rely on this file to ensure that the plugin graph understanding # | ||
# is equivalent to the compiler's. # | ||
# # | ||
# - Do not edit manually. # | ||
# - Commit changes to source control. # | ||
# - Since this file is autogenerated, code review changes carefully to # | ||
# ensure correctness. # | ||
# # | ||
######################################################################## | ||
|
||
------- | ||
| Scope | | ||
------- | ||
|
||
==== Required ==== | ||
|
||
==== Provides ==== | ||
|
||
---- boolean | Objects.myBoolean ---- | ||
[ Required ] | ||
[ Consumed By ] | ||
* Scope | Scope.myBoolean() | ||
|
||
---- byte | Objects.myByte ---- | ||
[ Required ] | ||
[ Consumed By ] | ||
* Scope | Scope.myByte() | ||
|
||
---- char | Objects.myChar ---- | ||
[ Required ] | ||
[ Consumed By ] | ||
* Scope | Scope.myChar() | ||
|
||
---- double | Objects.myDouble ---- | ||
[ Required ] | ||
[ Consumed By ] | ||
* Scope | Scope.myDouble() | ||
|
||
---- float | Objects.myFloat ---- | ||
[ Required ] | ||
[ Consumed By ] | ||
* Scope | Scope.myFloat() | ||
|
||
---- int | Objects.myInt ---- | ||
[ Required ] | ||
[ Consumed By ] | ||
* Scope | Scope.myInt() | ||
|
||
---- Object | Objects.myAny ---- | ||
[ Required ] | ||
[ Consumed By ] | ||
* Scope | Scope.myAny() | ||
|
||
---- Function2<Long,Double,Short> | Objects.function2 ---- | ||
[ Required ] | ||
[ Consumed By ] | ||
* ChildScope | Objects.myNull(function2) | ||
|
||
---- long | Objects.myLong ---- | ||
[ Required ] | ||
[ Consumed By ] | ||
* Scope | Scope.myLong() | ||
|
||
---- short | Objects.myShort ---- | ||
[ Required ] | ||
[ Consumed By ] | ||
* Scope | Scope.myShort() | ||
|
||
---- Scope | implicit ---- | ||
[ Required ] | ||
[ Consumed By ] | ||
|
||
------------ | ||
| ChildScope | | ||
------------ | ||
|
||
==== Required ==== | ||
|
||
---- Function2<Long,Double,Short> ---- | ||
[ Provided By ] | ||
* Scope | Objects.function2 | ||
[ Consumed By ] | ||
* ChildScope | Objects.myNull(function2) | ||
|
||
==== Provides ==== | ||
|
||
---- ChildScope | implicit ---- | ||
[ Required ] | ||
[ Consumed By ] | ||
|
||
---- Null | Objects.myNull ---- | ||
[ Required ] | ||
Function2<Long,Double,Short> | ||
[ Provided By ] | ||
* Scope | Objects.function2 | ||
[ Consumed By ] | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
/* | ||
* Copyright (c) 2023 Uber Technologies, Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package testcases.KT008_funky_names | ||
|
||
class Null(function2: @JvmSuppressWildcards ((Long, Double) -> Short)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
/* | ||
* Copyright (c) 2023 Uber Technologies, Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package testcases.KT008_funky_names | ||
|
||
import motif.Expose | ||
|
||
|
||
@motif.Scope | ||
interface Scope { | ||
|
||
fun child(): ChildScope | ||
|
||
fun myByte(): Byte | ||
|
||
fun myShort(): Short | ||
|
||
fun myInt(): Int | ||
|
||
fun myLong(): Long | ||
|
||
fun myFloat(): Float | ||
|
||
fun myDouble(): Double | ||
|
||
fun myBoolean(): Boolean | ||
|
||
fun myChar(): Char | ||
|
||
fun myAny(): Any | ||
|
||
@motif.Objects | ||
open class Objects { | ||
|
||
@Expose | ||
fun function2(): ((Long, Double) -> Short) = { _, d -> d.toInt().toShort() } | ||
|
||
fun myByte(): Byte = 3 | ||
|
||
fun myShort(): Short = 3 | ||
|
||
fun myInt(): Int = 3 | ||
|
||
fun myLong(): Long = 3 | ||
|
||
fun myFloat(): Float = 0.2f | ||
|
||
fun myDouble(): Double = 0.2 | ||
|
||
fun myBoolean(): Boolean = true | ||
|
||
fun myChar(): Char = 'c' | ||
|
||
fun myAny(): Any = Any() | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
/* | ||
* Copyright (c) 2023 Uber Technologies, Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package testcases.KT008_funky_names; | ||
|
||
import static com.google.common.truth.Truth.assertThat; | ||
|
||
public class Test { | ||
|
||
public static void run() { | ||
Scope scope = new ScopeImpl(); | ||
assertThat(scope.child()).isNotNull(); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to verify the name renderer change is not breaking stuff