Fix StackOverflowError on types with self-references

uber · Feb 14, 2024 · 13ad53a · 13ad53a
1 parent dfb9036
commit 13ad53a
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/compiler/ast/src/main/kotlin/com/uber/xprocessing/ext/XType.kt b/compiler/ast/src/main/kotlin/com/uber/xprocessing/ext/XType.kt
@@ -312,8 +312,16 @@ fun XType.isPrimitive(): Boolean {
 }
 
 private fun XType.hasCollectionType(): Boolean {
-  return this.typeElement?.name.orEmpty() in collectionTypes ||
-      typeArguments.any { it.hasCollectionType() }
+  val visited = mutableSetOf<XType>()
+  val queue = mutableListOf(this@hasCollectionType)
+  while (queue.isNotEmpty()) {
+    val type = queue.removeFirst()
+    if (type in visited) continue
+    if (type.typeElement?.name in collectionTypes) return true
+    visited.add(type)
+    queue.addAll(type.typeArguments)
+  }
+  return false
 }
 
 private val collectionTypes =