Feat : Cells to multipolygon #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Pull Request Test Coverage Report for Build 7499665938
💛 - Coveralls |
| @@ -98,8 +98,10 @@ type ( | |||
| } | |||
|
|
|||
| // LinkedGeoPolygon is a linked-list of GeoPolygons. | |||
| // TODO: not implemented. | |||
| LinkedGeoPolygon struct{} | |||
| LinkedGeoPolygon struct { | |||
There was a problem hiding this comment.
In uber/h3, this seems to be doubly-linked: https://github.com/uber/h3/blob/138a7487adb0892715ea7ced785db4e9c38842d1/src/h3lib/include/h3api.h.in#L179
Does that need to be maintained here?
| func CellsToMultiPolygon(cells []Cell) *LinkedGeoPolygon { | ||
| panic("not implemented") | ||
| var head, current *LinkedGeoPolygon |
There was a problem hiding this comment.
I'd expect this function to wrap cellsToMultiPolygon from the C core library, which handles details like ensuring duplicated internal vertices are not included. https://github.com/uber/h3/blob/138a7487adb0892715ea7ced785db4e9c38842d1/src/h3lib/include/h3api.h.in#L293
|
This was implemented in #70 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried adding my implementation for cellsToMultipolygon which was marked as TODO