-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Persian translation #196
Conversation
@jamalkaksouri the PR is still broken: All the PR needs is a new entry added to the README linking to your translation. |
Hey @jamalkaksouri, thanks for the translation! You don't need to include See the most recent translation update, #157, as well as the repository that it links to, as an example. |
Hello @mway, I want to express my gratitude for your guidance. As per your recommendation, I replaced the Persian translation in the style.md file. However, it appears that it automatically reverted back to its English equivalent. In the repository #157 many files and folders were not included, despite my previous attempts with this method, and the tests did not pass. Did I make a mistake? |
Hey, @jamalkaksouri, thanks for the translation. Our build process might be getting in the way a little. First, just to clarify: @mway suggested not to modify the style.md in this repository, but you're free to modify or replace style.md in your translation repository (jamalkaksouri/uber-go-guide-ir). Now, the reason that style.md reverted back to English is because of our build setup. We have the actual style guide contents inside the src directory. Afterwards, a CI Job merges the contents of the src directory into the style.md (relevant part). Typically, translation repositories aren't forks. They just translate the contents and have their own history. I think you're running into this problem because your repository is a fork -- so it's making it difficult to keep the style.md unchanged while still making a PR for the README. There are a couple ways you could go about fixing this. First option is: keep the repository a fork, but make the README PR from "before" the translation. Something like this:
Then for your translation on master (not on this branch), disable the CI job (delete the ci.yml file) and the src directory. Your translation will be maintained in the style.md and you can update it as needed. (You can revert the "Auto-update style.md" commit when you do that.) Second option is: use the fork only to add an entry to the README. Create a separate repository for the translation.
Hope this helps! |
Relatedly, @mway, we may want a section in the CONTRIBUTING.md about contributing translations. |
Agreed, I think that would be good. |
Thank you @abhinav, I would like to express my gratitude for your swift response and comprehensive guidance. I have implemented the second suggested approach, and the repository is now up-to-date and ready for merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Thanks, @jamalkaksouri.
In accordance with the guidelines outlined in the contributing file, the Persian translation of this repository has been completed.