Fixed a bug that prevented allocations from being disabled even after it has been denied or revoked #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuanMPhm
changed the title
jtriley
added a commit
to nerc-project/coldfront-nerc
that referenced
this pull request
Feb 17, 2024
Include latest versions of api, keycloaak, and cloud plugins. Includes a coldfront patch that has yet to be merged upstream to fix a bug that prevented allocations from being disabled even after it has been denied or revoked: ubccr/coldfront#596
jtriley
added a commit
to nerc-project/coldfront-nerc
that referenced
this pull request
Feb 20, 2024
Include latest versions of api, keycloak, and cloud plugins. Includes a coldfront patch that has yet to be merged upstream to fix a bug that prevented allocations from being disabled even after it has been denied or revoked: ubccr/coldfront#596
The if statement used the wrong operator to determine if the allocation status was changed to "Denied" or "Revoked" Signed-off-by: Quan Pham <[email protected]>
|
I've added the signoff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The if statement used the wrong operator to determine if the allocation status was changed to "Denied" or "Revoked". This prevented a signal from being sent that would indicated that the allocation should be disabled.