Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

casson-uom-thesis:0.1.0 #1500

Merged
merged 6 commits into from
Jan 20, 2025
Merged

casson-uom-thesis:0.1.0 #1500

merged 6 commits into from
Jan 20, 2025

Conversation

ALEX-CASSON-LAB
Copy link
Contributor

@ALEX-CASSON-LAB ALEX-CASSON-LAB commented Dec 31, 2024

I am submitting

  • a new package
  • an update for a package

Description: A PhD thesis template for the University of Manchester following our formatting guidelines

I have read and followed the submission guidelines and, in particular, I

  • [ X ] selected a name that isn't the most obvious or canonical name for what the package does
  • [ X ] added a typst.toml file with all required keys
  • [ X ] added a README.md with documentation for my package
  • [ X ] have chosen a license and added a LICENSE file or linked one in my README.md
  • [ X ] tested my package locally on my system and it worked
  • [ X ] excluded PDFs or README images, if any, but not the LICENSE
  • [ X ] ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

@typst-package-check typst-package-check bot changed the title University of Manchester PhD thesis template casson-uom-thesis:0.1.0 Dec 31, 2024
@typst-package-check typst-package-check bot added the new A new package submission. label Dec 31, 2024
Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the submission, I just have a few small remarks, but otherwise everything looks good!

entrypoint = "casson-uom-thesis.typ"
authors = ["Alex Casson <https://research.manchester.ac.uk/en/persons/alex.casson>"]
license = "MIT-0"
description = "Typst template based upon The University of Manchester Presentation of Theses Policy which relates to the examination of doctoral and MPhil degrees at The University of Manchester and applies to full-time and part-time postgraduate research students of the following degrees: Doctoral degrees: Doctor of Philosophy (PhD); Doctor of Medicine (MD) Doctor of Business Administration (DBA); Professional, Engineering and Enterprise Doctorates; Master of Philosophy (MPhil). This template has been checked to be compliant with the 2024 requirements. Responsibility for ensuring compliance with the University of Manchester Presentation of Theses Policy remains with the candidate."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is a bit long in my opinion and it won't look very good on Typst Universe. I would suggest making it a single sentence. If you want guidelines on how to write a good description, you can have a look at this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made this much shorter. The University will still want the disclaimer saying responsibility lies with the user, and so it is still two sentences.

packages/preview/casson-uom-thesis/0.1.0/README.md Outdated Show resolved Hide resolved
packages/preview/casson-uom-thesis/0.1.0/README.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@ALEX-CASSON-LAB ALEX-CASSON-LAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these comments. I've made the suggested changes.

entrypoint = "casson-uom-thesis.typ"
authors = ["Alex Casson <https://research.manchester.ac.uk/en/persons/alex.casson>"]
license = "MIT-0"
description = "Typst template based upon The University of Manchester Presentation of Theses Policy which relates to the examination of doctoral and MPhil degrees at The University of Manchester and applies to full-time and part-time postgraduate research students of the following degrees: Doctoral degrees: Doctor of Philosophy (PhD); Doctor of Medicine (MD) Doctor of Business Administration (DBA); Professional, Engineering and Enterprise Doctorates; Master of Philosophy (MPhil). This template has been checked to be compliant with the 2024 requirements. Responsibility for ensuring compliance with the University of Manchester Presentation of Theses Policy remains with the candidate."
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made this much shorter. The University will still want the disclaimer saying responsibility lies with the user, and so it is still two sentences.

Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if I wasn't clear, but I still think the import in the template needs to be changed.

packages/preview/casson-uom-thesis/0.1.0/template/main.typ Outdated Show resolved Hide resolved
Copy link
Contributor Author

@ALEX-CASSON-LAB ALEX-CASSON-LAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry mis-interpreted. Have accepted your change.

@elegaanz
Copy link
Member

Thanks!

@elegaanz elegaanz merged commit 72f8b06 into typst:main Jan 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new A new package submission.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants