fix: boolean handling in GET list

typicode · May 13, 2024 · 827c5c3 · 827c5c3
1 parent 8fb0f72
commit 827c5c3
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 3 deletions.
diff --git a/src/service.test.ts b/src/service.test.ts
@@ -21,20 +21,23 @@ const post1 = {
   id: '1',
   title: 'a',
   views: 100,
+  published: true,
   author: { name: 'foo' },
   tags: ['foo', 'bar'],
 }
 const post2 = {
   id: '2',
   title: 'b',
   views: 200,
+  published: false,
   author: { name: 'bar' },
   tags: ['bar'],
 }
 const post3 = {
   id: '3',
   title: 'c',
   views: 300,
+  published: false,
   author: { name: 'baz' },
   tags: ['foo'],
 }
@@ -183,7 +186,16 @@ await test('find', async (t) => {
         params: { _sort: '-views,id' },
         res: [post3, post2, post1],
       },
-
+      {
+        name: POSTS,
+        params: { published: 'true' },
+        res: [post1],
+      },
+      {
+        name: POSTS,
+        params: { published: 'false' },
+        res: [post2, post3],
+      },
       {
         name: POSTS,
         params: { _start: 0, _end: 2 },

diff --git a/src/service.ts b/src/service.ts
@@ -285,12 +285,26 @@ export class Service {
             }
             // item_ne=value
             case Condition.ne: {
-              if (!(itemValue != paramValue)) return false
+              switch (typeof itemValue) {
+                case 'number':
+                  return itemValue !== parseInt(paramValue)
+                case 'string':
+                  return itemValue !== paramValue
+                case 'boolean':
+                  return itemValue !== (paramValue === 'true')
+              }
               break
             }
             // item=value
             case Condition.default: {
-              if (!(itemValue == paramValue)) return false
+              switch (typeof itemValue) {
+                case 'number':
+                  return itemValue === parseInt(paramValue)
+                case 'string':
+                  return itemValue === paramValue
+                case 'boolean':
+                  return itemValue === (paramValue === 'true')
+              }
             }
           }
         }