Ground work for integration tests with real instance#43
Closed
erimicel wants to merge 8 commits intotypesense:masterfrom
Closed
Ground work for integration tests with real instance#43erimicel wants to merge 8 commits intotypesense:masterfrom
erimicel wants to merge 8 commits intotypesense:masterfrom
Conversation
tharropoulos
suggested changes
Mar 11, 2025
Contributor
tharropoulos
left a comment
tharropoulos
left a comment
There was a problem hiding this comment.
First of all, thank you for taking the time to implement those changes!
erimicel
changed the title
Contributor
There was a problem hiding this comment.
Could we leave dep bumps until after we've merged the test changes? Would prefer to avoid any side effects related to deps here
Contributor
Author
There was a problem hiding this comment.
These updates only for dev dependencies, imo would be nice to update these to latest before hand?
Gem dependencies are declared in .gemspec file
Contributor
There was a problem hiding this comment.
Most of the dep bumps are specifically for testing, so they should be fine. Although, I feel like they should be left as the last thing, so we don't need to bisect if something goes wrong with any dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Related: #42
This PR covers the groundwork for introducing integration/request tests with an actual Docker container;
PR Checklist