-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review with React 18 types in mind #495
Comments
In particular, the guide also mentions that |
I created #496 before I saw this. Let me know if you want to handle it in another way or feel free to just close the PR. |
The other place that came to mind was the section "Small But I'm not sure how you would like to convey this, so just let me know if you have other ideas. |
The main reason behind |
hey @filiptammergard really appreciate the comments! I just invited you to help maintain this repo :) i've personally never used React.FC so never engaged in that debate but let me know if the consensus shifts :) all i care about on that topic is just to give a concise summary of the tradeoffs if you choose ot use it |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions! |
From what I understand the last remaining pitfalls with React.FC were fixed with DefinitelyTyped/DefinitelyTyped@443451c released in https://unpkg.com/@types/[email protected]/index.d.ts ? I'm talking about these two:
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions! |
❤️ |
We had some type-related breaking changes with React 18 that were supposed to fix long standing issues. If we describe these issues here, reference React 18 types that fix those issues.
The text was updated successfully, but these errors were encountered: