Remove hardcoded dependency on default money context

[fredfp]

Squants market package is designed to allow defining a different set of currencies, with optional FX rates.

This flexibility is achieved by using an implicit MoneyContext parameter on some methods, with a default value set to squants.market.defaultMoneyContext. This way, one can define a new MoneyContext, and mark it implicit to have it used instead of the default.

This however isn't consistently implemented throughout the code base. It is especially missing on factory methods of the Money object which involve parsing a currency code. As a consequence, one cannot build Money instances using custom currencies (i.e., currencies which are not available in the squants market package).

This pull request is meant to fix this issue. It does so by removing any hard-coded references to the default currency set or default money context, and replacing them by an implicitly passed MoneyContext.

[fredfp]

@garyKeorkunian

[fredfp]

I missed #330 before creating this PR.

This one is slightly different: it keeps the current squants behaviour (i.e., crashing for missing currencies) which is a rather bad thing but was meant to trigger a conversation in here.

@cquiroz could you advise on which way to go to get one of those merged and released?

should fix #296

[cquiroz]

I'm a bit confused abou these. So #334 and #330 Do the same?

[fredfp]

They do the same except when parsing a Currency from a String:

• here, Remove hardcoded dependency on default money context #334, keeps the current squants behaviour i.e., throws when a currency cannot be parsed from a String
• Allow currency parsing from implicit context #330 changes the signature of a few Money.apply methods to return Try[Money] instead of Money.

I'd prefer having #330 merged

[garyKeorkunian]

#330 has been approved and will be merged soon.