Add @static3
#79
Merged
Add @static3
#79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satorg
reviewed
Dec 23, 2023
Comment on lines
+19
to
+21
| object CustomStaticHelper { | ||
| final val isScala3 = true | ||
| } |
There was a problem hiding this comment.
@armanbilge regarding this object. It looks good for this PR, but as I can see there are two other objects around - CustomTargetNameHelper and CustomThreadUnsafeHelper that presumably do exactly the same thing. I wonder if it makes sense (in another PR of course) to replace these three separate objects with a single unified one. Like ScalacVersionHelper or something like this?
There was a problem hiding this comment.
Yeah we should definitely do that. Every time I open one of these PRs I want to do it but I get lazy and succumb to copy-paste. 😅
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #72, this lets us use another fancy Scala 3 optimization while still cross-compiling for Scala 2.