Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#803 - add eval udf implementation - includes / requires #804 #806

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

chris-twiner
Copy link
Contributor

@chris-twiner chris-twiner commented Mar 21, 2024

This can be merged instead of #804 / #805, it requires the functionality.

per #803 any expression that needs further optimisation before compilation (like ExpressionProxy) fails when used in a UDF if they throw on doCodeGen.

This PR implements the expected Spark pattern of eval eval'ing. It requires the correct type derivation from #804 for both Seq and Set in order to work (due to MapObjects difference in eval vs compilation)

(cherry picked from commit caed43956187a52f1a37d8192b70bd9ecf297a1f)
…13 forced changes, compilation issue with toSeq():GenSeq
…13 forced changes, compilation issue with toSeq():GenSeq
…13 forced changes, compilation issue with toSeq():GenSeq
…13 forced changes, compilation issue with toSeq():GenSeq
…13 forced changes, compilation issue with toSeq():GenSeq
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 95.95960% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 95.56%. Comparing base (0fb9c58) to head (e157cdb).

Files Patch % Lines
...taset/src/main/scala/frameless/functions/Udf.scala 93.10% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #806      +/-   ##
==========================================
+ Coverage   95.46%   95.56%   +0.09%     
==========================================
  Files          67       68       +1     
  Lines        1257     1329      +72     
  Branches       42       45       +3     
==========================================
+ Hits         1200     1270      +70     
- Misses         57       59       +2     
Flag Coverage Δ
2.12-root-spark33 95.25% <91.91%> (-0.21%) ⬇️
2.12-root-spark34 95.48% <94.94%> (+0.02%) ⬆️
2.12-root-spark35 95.48% <94.94%> (+0.02%) ⬆️
2.13-root-spark35 96.04% <94.89%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant