-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#803 - add eval udf implementation - includes / requires #804 #806
Open
chris-twiner
wants to merge
21
commits into
typelevel:master
Choose a base branch
from
chris-twiner:temp/803_clean
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit caed43956187a52f1a37d8192b70bd9ecf297a1f)
…shtrieset no longer there on 2.13
…shtrieset no longer there on 2.13
…13 forced changes, compilation issue with toSeq():GenSeq
…13 forced changes, compilation issue with toSeq():GenSeq
…13 forced changes, compilation issue with toSeq():GenSeq
…13 forced changes, compilation issue with toSeq():GenSeq
…13 forced changes, compilation issue with toSeq():GenSeq
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #806 +/- ##
==========================================
+ Coverage 95.46% 95.56% +0.09%
==========================================
Files 67 68 +1
Lines 1257 1329 +72
Branches 42 45 +3
==========================================
+ Hits 1200 1270 +70
- Misses 57 59 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be merged instead of #804 / #805, it requires the functionality.
per #803 any expression that needs further optimisation before compilation (like ExpressionProxy) fails when used in a UDF if they throw on doCodeGen.
This PR implements the expected Spark pattern of eval eval'ing. It requires the correct type derivation from #804 for both Seq and Set in order to work (due to MapObjects difference in eval vs compilation)