Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field encoder #763

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

cchantep
Copy link
Collaborator

In case a type T encoding is supported in derivation (as a struct field), then this allows to resolve the corresponding TypedEncoder[T], so the field can be handled invidiually.

Copy link
Member

@pomadchin pomadchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Though formatting is off (see CI)

@@ -615,4 +615,36 @@ final class ColumnTests extends TypedDatasetSuite with Matchers {
// we should be able to block the following as well...
"ds.col(_.a.toInt)" shouldNot typeCheck
}

test("col through record encoder (for Value class)") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants