-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement the FlatMap typeclass on Job. This allows Job to be used as a Kleisli/Reader #336
base: master
Are you sure you want to change the base?
Conversation
… a Reader and composesed
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
==========================================
- Coverage 96.34% 96.08% -0.26%
==========================================
Files 57 60 +3
Lines 1012 1048 +36
Branches 10 9 -1
==========================================
+ Hits 975 1007 +32
- Misses 37 41 +4
Continue to review full report at Codecov.
|
Hey @gregnwosu, do you want to keep this open? I would love to merge the PR if you can make the tests pass (adding a test may help with coverage). Let me know if you have any questions. |
Yes please I will write the tests this weekend |
this pull request allows us to make Job into cats Reader/Kleisli monads. It opens up the proper monad stack for Job and enables the potential to use Job in Monad Transformer stacks . Some example code will probably help explain this best.