Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URLs #989

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Update URLs #989

wants to merge 32 commits into from

Conversation

jsoref
Copy link

@jsoref jsoref commented Jul 31, 2022

Description

Generally https urls should be preferred over http urls.
Also, live urls should be preferred over dead ones.

Note that I tend to leave distinct changes as distinct commits as it makes it easier for me to drop things that groups don't like. I'm not attached to any of these individual changes, nor their structure. I'm happy to squash, although I prefer to do that after the changes are accepted (and I'm happier to let someone else squash and pick a commit message).

How Has This Been Tested?

I used a simple script that checked to see if it looked like pages were available via https:

check() { curl -I "$1"; curl -I "$(echo "$1" | perl -pe 's<http:><https:>')"; }

And had a handy script to update them if they did:

update() { rs "$1" "$(echo "$1" | perl -pe 's<http:><https:>')" "https"; }     

For a number of things that failed or provided redirects, I followed them.

Note that I left a handful of dead dangling links as http (and msys insists on using http, so...)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change
  • Test suite change

Checklist:

  • I have read the CONTRIBUTING document.

jsoref added 30 commits July 31, 2022 11:39
Signed-off-by: Josh Soref <[email protected]>
So is /2 ... this is the replacement for /2 ...
@@ -56,7 +56,7 @@ The algorithm used is based on the paper:
"GADTs Meet Their Match:
Pattern-matching Warnings That Account for GADTs, Guards, and Laziness"

http://people.cs.kuleuven.be/~george.karachalias/papers/p424-karachalias.pdf
https://web.archive.org/web/20170706035904/https://people.cs.kuleuven.be/~george.karachalias/papers/p424-karachalias.pdf
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a page wasn't reachable, I sometimes tried to find an archived version of the document. I didn't try for every page, and I have not done any checking on current https links -- that's beyond the scope of this PR.

@@ -334,7 +334,7 @@ data IfaceIdDetails
{-
Note [Versioning of instances]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
See [http://ghc.haskell.org/trac/ghc/wiki/Commentary/Compiler/RecompilationAvoidance#Instances]
See [https://gitlab.haskell.org/ghc/ghc/-/wikis/commentary/compiler/recompilation-avoidance#Instances]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My tooling ignored everything after the #, so it's possible that it's no longer correct, but that shouldn't be a big deal (if someone wants to make further corrections, they're welcome to do so).

Comment on lines 363 to +364
in Trac #1496. The full story is in docs/core-spec/core-spec.pdf. Also, see
http://ghc.haskell.org/trac/ghc/wiki/RolesImplementation
https://gitlab.haskell.org/ghc/ghc/-/wikis/roles-implementation
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I know that the text still says it's Trac and that it in fact is now in gitlab. I consciously chose not to update the text. The item was indeed articulated in Trac #1496, it just so happens that the resource now lives elsewhere.

If someone wants to rewrite the prose, they can.

@@ -6,7 +6,7 @@
* based on "The Design of a Pretty-printing Library" *
* in Advanced Functional Programming, *
* Johan Jeuring and Erik Meijer (eds), LNCS 925 *
* http://www.cs.chalmers.se/~rjmh/Papers/pretty.ps *
* https://web.archive.org/web/20070203205021/http://www.cs.chalmers.se/~rjmh/Papers/pretty.ps *
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this blows the ascii art boundary. I'm not certain what people would prefer to do. URL wrapping is not a good thing. Even deleting all whitespaces wouldn't result in a url that fits...

@@ -108,13 +108,11 @@ The `maven-repos` field can take a URL to a Maven repository OR a keyword from t
| Keyword | Maven Repository URL |
| -------------------------- | -------------------------------------------------------- |
| `central` | `https://repo1.maven.org/maven2/` |
| `javaNet1` | `http://download.java.net/maven/1/` |
| `javaNet1` | `https://maven.java.net/content/groups/public/` |
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • maven/1/ is dead
  • as is maven/2/

This url corresponds to maven/2/ -- I'm not sure if this is the right choice. My initial reaction was to just delete the line entirely.

Comment on lines 113 to -114
| `jcenter` | `https://jcenter.bintray.com/` |
| `bintray:[owner]:[repo]` | `https://dl.bintray.com/[owner]/[repo]/` |
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bintray is gone. They wanted to kill jcenter as well but too many people protested, so it has an indefinite reprieve.

@@ -231,7 +231,7 @@ inline the entire definition (as happens for foldr, for example) thereby
specialising for the particular action.

For further information, see this Trac comment, which includes side-by-side
Core: https://ghc.haskell.org/trac/ghc/ticket/11795#comment:6
Core: https://gitlab.haskell.org/ghc/ghc/-/issues/11795#comment:6
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted earlier, the # suffixes are not updated. Updating the bits would require a lot of effort and I'd rather leave the human readable text than risk getting the update wrong.

@@ -3,7 +3,7 @@ version: 4.11.1.0
license: BSD3
license-file: LICENSE
maintainer: [email protected]
bug-reports: http://ghc.haskell.org/trac/ghc/newticket?component=libraries/base
bug-reports: https://gitlab.haskell.org/ghc/ghc/-/issues/new
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the url structure beyond /new. It's unfortunate that this information isn't current, I might have wanted to file bugs against these libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant