Use __new__
instead of __init__
in serializers
#315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #260. This is starting to be really tricky to handle, so I don't know if this is a viable option. Regarding
ModelSerializer
, we might want to define the sameoverload
, and only allow specific types forinstance
with respect tomany
(e.g. ifmany=False
, only allow_MT
, but I'm unsure there's other types that could be allowed as well).Note:
__init__
has been omitted, otherwise mypy will not infer the correct return type from__new__