feat: introduce a memory for retry::Policy #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea introduced, here, is to add a "memory" parameter for the retry policy. If a long-running retryable operation (like chainsync) fails sporadically then the downstream oura user may not actually want the retry counter to increment. By default, the memory should be longer than the longest possible delay. If this isn't done then max_retries will never be encountered and retry_operation will never return. This case (never returning) may be desirable in some cases (like for a daemon application). But, it should not be the default case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The idea introduced, here, is to add a "memory" parameter for the retry policy. If a long-running retryable operation (like chainsync) fails sporadically then the downstream oura user may not actually want the retry counter to increment. By default, the memory should be longer than the longest possible delay. If this isn't done then max_retries will never be encountered and retry_operation will never return. This case (never returning) may be desirable in some cases (like for a daemon application). But, it should not be the default case.