-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to plant swamp trees. #140
Conversation
Objects:
Categories:
Details+ 14819 Brick Wall with Windowsill# +noBackAccess +useOnContained
+ 14828 Ancient Brick Wall with Windowsill# +noBackAccess +useOnContained
+ 14829 Wooden Wall with Windowsill# +noBackAccess +useOnContained
+ 14834 Dark Wooden Wall with Windowsill# +noBackAccess +useOnContained
+ 14837 Light Wooden Wall with Windowsill +noBackAccess +useOnContained
+ 14848 Half Brick Wall with Shelf# +useOnContained
+ 14854 Ancient Half Brick Wall with Shelf# +useOnContained
+ 14857 Half Sandstone Wall with Shelf# +useOnContained
+ 14859 Ancient Half Sandstone Wall with Shelf# +useOnContained
Details+ 14854 Ancient Half Brick Wall with Shelf# +useOnContained
+ 14848 Half Brick Wall with Shelf# +useOnContained
+ 14859 Ancient Half Sandstone Wall with Shelf# +useOnContained
+ 14857 Half Sandstone Wall with Shelf# +useOnContained
Details+ 22356 Staked Willow Tree
+ 22366 Staked Bald Cypress Tree
Details+ 527 Willow Tree
+ 530 Bald Cypress Tree
Details+ 22355 Willow Tree in Tree Pit
+ 22364 Bald Cypress in Tree Pit
Details+ 22357 Willow Tree with Small Cut Stones
+ 22365 Bald Cypress Tree with Small Cut Stones
Details+ 22350 Shears with Willow Cutting
+ 22349 Shears with Bald Cypress Cutting
Details+ 527 Willow Tree
+ 530 Bald Cypress Tree
Details+ 22350 Shears with Willow Cutting
+ 22349 Shears with Bald Cypress Cutting
Details+ 14819 Brick Wall with Windowsill# +noBackAccess +useOnContained
+ 14828 Ancient Brick Wall with Windowsill# +noBackAccess +useOnContained
+ 14829 Wooden Wall with Windowsill# +noBackAccess +useOnContained
+ 14834 Dark Wooden Wall with Windowsill# +noBackAccess +useOnContained
+ 14837 Light Wooden Wall with Windowsill +noBackAccess +useOnContained
+ 14848 Half Brick Wall with Shelf# +useOnContained
+ 14854 Ancient Half Brick Wall with Shelf# +useOnContained
+ 14857 Half Sandstone Wall with Shelf# +useOnContained
+ 14859 Ancient Half Sandstone Wall with Shelf# +useOnContained
Details+ 14821 Brick Wall with Window and Boards
+ 14826 Ancient Brick Wall with Window and Boards
+ 14831 Wooden Wall with Window and Boards
+ 14832 Dark Wooden Wall with Window and Boards
+ 14835 Light Wooden Wall with Window and Boards
Details+ 14819 Brick Wall with Windowsill# +noBackAccess +useOnContained
+ 14828 Ancient Brick Wall with Windowsill# +noBackAccess +useOnContained
+ 14829 Wooden Wall with Windowsill# +noBackAccess +useOnContained
+ 14834 Dark Wooden Wall with Windowsill# +noBackAccess +useOnContained
+ 14837 Light Wooden Wall with Windowsill +noBackAccess +useOnContained
Details+ 12273 Brick Wall with Window
+ 12427 Ancient Brick Wall with Window
+ 7697 Wooden Wall with Window
+ 7970 Wooden Wall with Window
+ 7971 Wooden Wall with Window
Details+ 14820 Brick Wall with Window and Boards#just removed
+ 14827 Ancient Brick Wall with Window and Boards#just removed
+ 14830 Wooden Wall with Window and Boards#just removed
+ 14833 Dark Wooden Wall with Window and Boards#just removed
+ 14836 Light Wooden Wall with Window and Boards#just removed
Details+ 7019 Half Stone Wall
+ 7021 Ancient Half Stone Wall
+ 10025 Brick Half Wall
+ 12901 Ancient Brick Half Wall
+ 10027 Sandstone Half Wall
+ 12905 Ancient Sandstone Half Wall
Details+ 7020 Half Stone Wall with Shelf# +useOnContained
+ 7022 Ancient Half Stone Wall with Shelf# +useOnContained
+ 14848 Half Brick Wall with Shelf# +useOnContained
+ 14854 Ancient Half Brick Wall with Shelf# +useOnContained
+ 14857 Half Sandstone Wall with Shelf# +useOnContained
+ 14859 Ancient Half Sandstone Wall with Shelf# +useOnContained
Details+ 7025 Half Stone Wall with Boards
+ 7026 Ancient Half Stone Wall with Boards
+ 14849 Half Brick Wall with Boards
+ 14853 Ancient Half Brick Wall with Boards
+ 14856 Half Sandstone Wall with Boards
+ 14858 Ancient Sandstone Half Wall With Boards
Details+ 22345 Dry Willow Sapling Cutting
+ 22339 Dry Bald Cypress Sapling Cutting
Details+ 22346 Wet Willow Sapling Cutting
+ 22340 Wet Bald Cypress Sapling Cutting
Details+ 22343 Willow Tree Cutting
+ 22337 Bald Cypress Tree Cutting
Details+ 22347 Dry Willow Sapling
+ 22341 Dry Bald Cypress Sapling
Details+ 22348 Wet Willow Sapling
+ 22342 Wet Bald Cypress Sapling
Details+ 22347 Dry Willow Sapling
+ 22348 Wet Willow Sapling
Details+ 22345 Dry Willow Sapling Cutting
+ 22346 Wet Willow Sapling Cutting
Details+ 22341 Dry Bald Cypress Sapling
+ 22342 Wet Bald Cypress Sapling
Details+ 22339 Dry Bald Cypress Sapling Cutting
+ 22340 Wet Bald Cypress Sapling Cutting
Details+ 22343 Willow Tree Cutting
+ 22337 Bald Cypress Tree Cutting
Details+ 22344 Rooting Willow Tree Cutting
+ 22338 Rooting Bald Cypress Tree Cutting
Details+ 22345 Dry Willow Sapling Cutting
+ 22339 Dry Bald Cypress Sapling Cutting Transitions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot of hard work on this PR—great job! We reviewed it together with @zabala6 , and it's clear you've put a lot of effort into it. Everything seems to work as expected, although we only tested sprinklers minimally. Here are some key highlights:
Functionality: The features worked as intended (sprinklers were not fully tested, but everything else looked good).
Consistency: The naming conventions are consistent across the board.
However, there are a few areas to improve:
Sprites: The sprites have been imported with default settings, leading to a shadowy appearance. Consider using these import settings:
Shadow: 0%
Black threshold: 100%
(not set in stone - but these settings tend to work for me)
Animation Adjustments: In "Animation --> Scene," the alignment of the Willow tree cutting and rooting cutting is off when held by the female character. Please adjust the hold position—use the maple cutting as a reference point.
Shears Transition: Shears with only one use can't interact with Willow and Cypress trees. Please add a transition for the last use.
Willow Tree Sprite: The top part of the "Willow Tree in Tree Pit" has the wrong sprite—it has Bay Tree sprite at the top hiding in branches.
Awesome work overall, and we are excited to see these changes in action! Keep it up!
Thank you very much for testing! All of the issues noted are addressed and fixed. |
Good job. I couldn't find any bugs. Finally we will be able to replant swamp! |
Merging #151 instead |
This request adds Willow and Bald Cypress cuttings as well as the ability to add these trees to the tree pits.
As to why they should be added, here is my short thesis on the subject.
-Enhancing Aesthetics of Swamp Biomes:
Swamp biomes can often look barren and uninviting due to the lack of vegetation. Plantable swamp trees would allow players to add greenery and life to these areas, making them more visually appealing and realistic within the game world.
-Reducing the anxiety of nature lovers:
Swamp areas are currently the go-to location for collecting firewood and logs, which can be a constant source of anxiety for players who prefer to maintain the natural surroundings of their towns. Personally, I have witnessed numerous arguments related to this issue.
-Adding Decorative Options:
Plantable swamp trees would provide players with additional decorative options for landscaping and town-building. They can be used to create lush gardens or atmospheric settings within towns.
Encouraging Creative Building:
Allowing players to plant swamp trees encourages creativity in town-building and landscaping. Players can experiment with different layouts, designs, and combinations of swamp vegetation to personalize their surroundings.
The thesis has been rendered more readable with the assistance of our helpful, though not entirely sentient algorithm.