Skip to content
This repository has been archived by the owner on Nov 13, 2021. It is now read-only.

Store timestamp as POSIXct, not POSIXlt #92

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

caijun
Copy link

@caijun caijun commented Nov 18, 2017

To fix the Error: Column timestamp is a date/time and must be stored as POSIXct, not POSIXlt, we should store the timstamp variable as POSIXct, not POSIXlt, which also make it compatible with dplyr, ggplot2 etc. packages that requires putting POSIXct in a data frame. see issue tidyverse/dplyr#179

This PR may also fix the issue #2

@CLAassistant
Copy link

CLAassistant commented Dec 20, 2017

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

@amurthy-perf amurthy-perf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dataset here (https://www.kaggle.com/boltzmannbrain/nab) needs this code change.
Looksgood.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants