Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for NullReferenceException when GetService<IHttpClientFactory>() fails #114

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

amazur31
Copy link

Fix for this #98

It's 2:20 AM
I was stuck on this error for too long...
To whoever didn't fix it the first time - fuck you.
To the creator of AspNetCore.Proxy - thank you.

src/Core/Extensions/Http.cs Outdated Show resolved Hide resolved
@twitchax
Copy link
Owner

@amazur31, can you also add a test for this? Basically, want to make sure this doesn't get regressed.

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.97%. Comparing base (b3f70af) to head (e9393fd).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/Core/Extensions/Http.cs 66.66% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
- Coverage   99.85%   98.97%   -0.88%     
==========================================
  Files          12       12              
  Lines         686      686              
  Branches       84       86       +2     
==========================================
- Hits          685      679       -6     
  Misses          1        1              
- Partials        0        6       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twitchax twitchax merged commit bdc100b into twitchax:master Aug 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants