[WIP] SVGs: Allow for Aspect variations of scale. #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Work in progress efforts toward issue #44. Not ready to merge.)
This will eventually allow for scaling SVGs in a given rendering size using the various
Xamarin.Forms.Aspect
enum values:AspectFit
: proportionally scaled and smaller by "letterboxing" (default)AspectFill
: proportionally scaled and larger by "cropping"Fill
: just stretched to fit the available spaceDefinitely still needed:
Aspect.Fill
(e.g., always the full width in the sample page, even whenWidthRequest
smaller)Aspect.AspectFill
(just flat out wrong in the sample, but maybe it's failing to recenter the rendered result on the final size)Aspect.AspectFit
when size is determined by layout (e.g., omitting WidthRequest)