-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IntlExtension::formatDateTime use of date formatter prototype #3844
Conversation
See twigphp/intl-extra#6 for more details
It would be great to have tests to prevent regressions. |
Voilà! |
Thank you @drjayvee. |
…totype (drjayvee) This PR was squashed before being merged into the 3.x branch. Discussion ---------- Fix IntlExtension::formatDateTime use of date formatter prototype See twigphp/intl-extra#6 for more details Commits ------- c75762c Fix IntlExtension::formatDateTime use of date formatter prototype
Merged |
This change seems to break the fallback of using the timezone set in twigs if (false === $formatterTimezone) {
$formatterTimezone = $date->getTimezone();
Quickfix would be to use: if (null === $formatterTimezone) {
$formatterTimezone = $date->getTimezone(); |
This is probably a regression from twigphp#3844
…ulinho) This PR was merged into the 3.x branch. Discussion ---------- Fix timezone fallback to CoreExtension in IntlExtension This is probably a regression from #3844 Refer to my comment on the original MR: #3844 (comment) Commits ------- 144c4da Fix timezone fallback to CoreExtension in IntlExtension
…ulinho) This PR was merged into the 3.x branch. Discussion ---------- Fix timezone fallback to CoreExtension in IntlExtension This is probably a regression from #3844 Refer to my comment on the original MR: twigphp/Twig#3844 (comment) Commits ------- 144c4dac Fix timezone fallback to CoreExtension in IntlExtension
See twigphp/intl-extra#6 for more details