Ability to Filter by Creation Source #7078
Conversation
![gitstart-app[bot]](https://avatars.githubusercontent.com/in/46283?s=60&v=4){kind=small}
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request implements the ability to filter records by Creation Source, addressing issue #6808. Key changes include:
- Added 'SOURCE' filter type in FilterType.ts and related components
- Implemented sub-menu functionality for 'ACTOR' filter type in ObjectFilterDropdownFilterSelect.tsx
- Created new ObjectFilterDropdownSourceSelect.tsx component for source filtering
- Updated turnObjectDropdownFilterIntoQueryFilter.ts to handle 'SOURCE' subfield in ACTOR filters
- Modified FilterDefinition type to include optional 'subFieldType' for more granular filtering
- Added utility functions getSubMenuOptions.ts and hasSubMenuFilter.ts to support new filtering structure
15 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
| {getSubMenuOptions(currentSubMenu) | ||
| .sort((a, b) => a.name.localeCompare(b.name)) | ||
| .filter((item) => | ||
| item.name | ||
| .toLocaleLowerCase() | ||
| .includes(searchText.toLocaleLowerCase()), | ||
| ) |
There was a problem hiding this comment.
style: Consider memoizing this filtered and sorted array to optimize performance
| [rawUIFilter.definition.subFieldType.toLowerCase()]: { | ||
| in: parsedRecordIds, | ||
| } as RelationFilter, |
There was a problem hiding this comment.
logic: Dynamic subfield type access might cause issues if subFieldType is unexpected
gitstart-twenty
changed the title
| </SelectableList> | ||
| {!currentSubMenu ? ( | ||
| <> | ||
| <StyledInput |
There was a problem hiding this comment.
Could you please extract this into a component because this ternary is quite heavy to read
| import { useSelectableList } from '@/ui/layout/selectable-list/hooks/useSelectableList'; | ||
| import { MenuItemSelect } from '@/ui/navigation/menu-item/components/MenuItemSelect'; | ||
| import { useRecoilValue } from 'recoil'; | ||
| import { useIcons } from 'twenty-ui'; | ||
|
|
||
| export type ObjectFilterDropdownFilterSelectMenuItemProps = { | ||
| filterDefinition: FilterDefinition; | ||
| setCurrentSubMenu: (subMenu: FilterType) => void; |
There was a problem hiding this comment.
Avoid passing setters in props, it's an anti-pattern, use recoil states instead.
| const selectedFilter = useRecoilValue(selectedFilterState); | ||
|
|
||
| // Dynamically update sourceEnumOptions based on selectedRecordIds | ||
| const sourceEnumOptions: SelectableRecord[] = [ |
There was a problem hiding this comment.
Could you extract this into a util with proper self-explanatory naming ?
|
|
||
| export const ObjectFilterSelectSubMenu = ({ | ||
| currentSubMenu, | ||
| setCurrentSubMenu, |
There was a problem hiding this comment.
This should be a recoil state
| }: ObjectFilterSelectSubMenuProps) => { | ||
| const [searchText, setSearchText] = useState(''); | ||
|
|
||
| const getHeaderTitle = (subMenu: FilterType | null) => { |
There was a problem hiding this comment.
Extract this into its own file
| @@ -0,0 +1,3 @@ | |||
| import { FilterType } from '@/object-record/object-filter-dropdown/types/FilterType'; | |||
|
|
|||
| export const hasSubMenuFilter = (type: FilterType) => ['ACTOR'].includes(type); | |||
| import { ViewFilter } from '../types/ViewFilter'; | ||
|
|
||
| const getDefinitionForFilter = ( |
There was a problem hiding this comment.
Extract this into a util and rename getFilterDefinitionForViewFilter
|
Thanks for the review @lucasbordeau , We are working on it |
This PR was created by GitStart to address the requirements from this ticket: TWNTY-6808.
This ticket was imported from: TWNTY-6808
Description
Demo
LOOM: https://www.loom.com/share/dba9c3d37a4242fe90f977b1babffbde?sid=59b07c51-d245-43cc-bb38-7d898ef72878
Refs
#6808
Fixes #6808