Show email in RecordChip on Email Thread Right Drawer #6943
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds email display functionality to the RecordChip component in the email threads view, modifying several components to accommodate this new feature.
- Added 'email' prop to ParticipantChip and RecordChip components in
/packages/twenty-front/src/modules/activities/components/ParticipantChip.tsxand/packages/twenty-front/src/modules/object-record/components/RecordChip.tsx - Modified AvatarChip in
/packages/twenty-ui/src/display/chip/components/AvatarChip.tsxto include email display and increase maxWidth when email is present - Introduced 'maxWidth' prop to Chip component in
/packages/twenty-ui/src/display/chip/components/Chip.tsxfor better width control - Potential UI layout and styling implications across the application due to changes in chip components
4 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
| maxWidth={email ? 350 : 200} | ||
| label={email ? `${name} <${email}>` : name} |
There was a problem hiding this comment.
style: Consider using a constant for maxWidth values instead of hardcoding
| @@ -50,7 +52,8 @@ export const AvatarChip = ({ | |||
|
|
|||
| return ( | |||
| <Chip | |||
| label={name} | |||
| maxWidth={email ? 350 : 200} | |||
| label={email ? `${name} <${email}>` : name} | |||
There was a problem hiding this comment.
style: Email display format might need refinement for better UI/UX
|
Indeed, we shouldn't put the person's name on the chip. Instead, we should display a tooltip when someone clicks on the CleanShot.2024-09-24.at.18.20.11.mp4FigmaUse the prototype to see the behavior by clicking play. tell me if you want to handle it. Otherwise happy to open a new issue! Thanks @gvkhna |
|
Closing this, you can create an issue @Bonapara :) |
Here's a simple PR to add the email to the record chip in the email threads view. This is really just an attempt to get my feet wet with the code base so I don't expect it to be accepted as-is. But wanted to get it looked at.
I understand there may be considerations about how to display the email. I would prefer a more muted color for the email text, perhaps a bit smaller, similar to how gmail does it. Also this is a simple way to get the email drilled through the many layers not sure if this is the desired method of extending the AvatarChip.
Here's what it looks like, this is a rather simple
it just workstype of commit.Also note, the Chip is currently not extending the maxWidth property which I had to add to get the email to not be truncated. Seems to work fine otherwise.
Update: apologies closed the previous, copied here, sorry for the mess, moved to it's own branch, opened as draft.