Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package management #1903

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

Package management #1903

wants to merge 15 commits into from

Conversation

jneem
Copy link
Member

@jneem jneem commented May 1, 2024

This is a hacky prototype of package management. I'm pushing it here not because it's useful yet, but to see if it's a direction we want to pursue.

First of all, I think we had discussed trying to piggy-back off npm (or other registries), but their terms (specifically, point 4) seem to prohibit it. So this prototype ditches registries altogether, allowing only git deps and path deps. In particular, we don't have any version resolution yet.

Anyway, what this PR allows is imports like import "file.ncl"@my-org/my-package. For such imports to work, you need to specify a manifest file that lists the "my-org/my-package" package. The manifest files are not auto-detected; you need to explicitly provide them with the --manifest-file option. So for example, given these files:

# foo/package.ncl
{
  name = "example/foo",
  version = "0.1.0",

  dependencies = {
    "example/leaf" = 'Path "../leaf"
    "jneem/ncl-package" = 'Git { url = "https://github.com/jneem/ncl-package.git" },

  },
} | std.package.Manifest
# foo/main.ncl
(import "hi.ncl"@example/foo) ++ ((import "package.ncl")@jneem/ncl-package).version
# leaf/package.ncl
{
  name = "example/leaf",
  version = "0.1.0",
} | std.package.Manifest
# leaf/hi.ncl
"hi"

if you run nickel eval --manifest-file foo/package.ncl foo/main.ncl it will print "hi0.1.0".

The current prototype allows for different copies of the same package, and it properly keeps them separate: if you depend on "example/foo" from one location and one of your dependencies depends on "example/foo" from some other location, import "bar.ncl"@example/foo will be interpreted according to whether it appears in your code or your dependency's code.

@github-actions github-actions bot temporarily deployed to pull request May 1, 2024 21:28 Inactive
@ShalokShalom
Copy link

I have already shared this on the Discord with @yannham, hope its fine to bring it in this discussion here also.

This one is Rust based, and self aware about many aspects, that need to be explicitly typed in other package management solutions.

I found it very easy to package, as its files need very little input.
Another rather rare benefit is, that is it available on Windows.

https://github.com/habitat-sh/habitat

@jneem
Copy link
Member Author

jneem commented May 3, 2024

Thanks for sharing this! It will be cool if we can piggy-back on their registry instead of building our own. But even if we can, there are definitely some package-management parts that we'll have to build ourselves (like having the interpreter understand imports from packages vs imports from the local filesystem). I'm going to focus on this part first, and look into the registry aspect later.

I did look into their docs a bit and it seems to be focused on running services. Do you know if they have a mode where you can just say "give me a bunch of files (including transitive deps) and put them in a well-known place"?

@ShalokShalom
Copy link

Thanks for sharing this! It will be cool if we can piggy-back on their registry instead of building our own. But even if we can, there are definitely some package-management parts that we'll have to build ourselves (like having the interpreter understand imports from packages vs imports from the local filesystem). I'm going to focus on this part first, and look into the registry aspect later.

I did look into their docs a bit and it seems to be focused on running services. Do you know if they have a mode where you can just say "give me a bunch of files (including transitive deps) and put them in a well-known place"?

I really recommend that you ask these questions the Habitat folks directly. I did use it a couple of years ago, and dont remember most.

@github-actions github-actions bot temporarily deployed to pull request May 7, 2024 03:00 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 9, 2024 15:28 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 10, 2024 19:25 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 13, 2024 23:36 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 14, 2024 01:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 24, 2024 03:45 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 24, 2024 03:51 Inactive
@jneem jneem mentioned this pull request May 24, 2024
@github-actions github-actions bot temporarily deployed to pull request May 24, 2024 17:26 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 24, 2024 22:12 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 24, 2024 22:32 Inactive
@jneem
Copy link
Member Author

jneem commented May 24, 2024

The macOS build is failing because of this, which no one seems to know how to solve...

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants