Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document projectDir dependencies #476

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

balsoft
Copy link
Collaborator

@balsoft balsoft commented Apr 19, 2023

Document that you need to have the kernel as a dependency if you're using projectDir.

Figured this out with @GuillaumeDesforges

@balsoft balsoft requested a review from k1nkreet as a code owner April 19, 2023 14:28
@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for tweag-jupyterwith ready!

Name Link
🔨 Latest commit c323988
🔍 Latest deploy log https://app.netlify.com/sites/tweag-jupyterwith/deploys/643ffa8bb9d75e0008f21369
😎 Deploy Preview https://deploy-preview-476--tweag-jupyterwith.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@@ -14,6 +14,9 @@ in {
description = lib.mdDoc ''
Path to the root of the poetry project that provides this ${kernelName}
kernel.

This poetry project must have the required kernel as a dependency.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an illustrative example of the most common case

Suggested change
This poetry project must have the required kernel as a dependency.
This poetry project must have the required kernel as a dependency.
For instance, for a Python kernel, you need the `ipykernel` package.

@github-actions
Copy link
Contributor

@github-actions github-actions bot temporarily deployed to pull request April 19, 2023 14:36 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants