Fix pointer conversion on recent Julia versions #17
+16
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base.unsafe_convertwas used onMatrixto obtain a pointer to the underlying data, but this breaks on the most recent Julia versions (at least it does on nightly), possibly due to theMemoryPR.The correct way to use it would have been to use
Base.unsafe_converton the result ofBase.cconvert, but I think that for matrices it is a better practice to usepointerdirectly.I also added a few missing
GC.@preservealong the way.These changes fix tests on nightly.