Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bump version of semver to address vulnerability warnings #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TimothyJones
Copy link
Collaborator

This PR:

  1. Bumps the version of semver to address the vulnerabiltiy warning
  2. Fixes the test that broke after the version bump (this is the reason that this automated PR failed)
  3. Swaps the deprecated standard-version for the most popular fork, commit-and-tag-version, which additionally addresses some vulnerability warnings.

Full disclosure, I maintain commit-and-tag-version - it's a fork of the now-unmaintained standard-version, which has had some good traction. Aside: this repository now doesn't actually need either tool - it would be better to use release-please, which is a much more streamlined release process for repositories hosted in github.

@tvdstaaij The semver issue is causing a few downstream vulnerability warnings - it would be awesome to get this in and released. Let me know if you'd like a version of this PR without introducing a tool that I maintain - I remember you were quite careful with security.

Hope you're well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant