Skip to content

feat(markdown): add NMarkdown #7410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rwv wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(markdown): add NMarkdown #7410

rwv wants to merge 2 commits into from

Conversation

@rwv
Copy link

@rwv rwv commented Jan 7, 2026 •
edited
Loading

What

  • Add NMarkdown runtime Markdown renderer (token -> VNode).
  • Support code blocks with injected highlight.js (same pattern as NCode).
  • Add sanitize options: sanitize (default true) strips unsafe URLs and escapes raw HTML; sanitizeHtml hook enables rendering sanitized HTML when needed.
  • Add demos (basic/hljs/security) and unit tests.

@jahnli
Copy link
Collaborator

jahnli commented Jan 9, 2026

👍

Sepush
Sepush reviewed Jan 15, 2026
View reviewed changes
src/markdown/src/Markdown.tsx
@@ -0,0 +1,468 @@
import type { Token, Tokens } from 'marked'
Copy link
Collaborator

@Sepush Sepush Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • prefer https://unifiedjs.com/ remarkjs stack
  • due to package size, Naive UI doesn't include the package
  • the approach should be like n-code n-hilight n-equation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sepush Sepush Sepush left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rwv @jahnli @Sepush