Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add slots typing for all components #6603

Open
wants to merge 54 commits into
base: main
Choose a base branch
from
Open

feat: add slots typing for all components #6603

wants to merge 54 commits into from
+705 −72

Conversation

Groupguanfang
Copy link

@Groupguanfang Groupguanfang commented Dec 7, 2024 •
edited by jahnli
Loading

close #6599

@nailiable
feat(alert): add slots type (tusen-ai#6599)
16e0e8b
@nailiable
feat(auto-complete): add slots type (tusen-ai#6599)
19d637f
@nailiable
fix(auto-complete): slots type (tusen-ai#6599)
f4799d1
@nailiable
feat(auto-complete): export slots type (tusen-ai#6599)
00c775c
@nailiable
feat(avatar): add slots type (tusen-ai#6599)
6efc1ff
@nailiable
feat(avatar-group): add slots type (tusen-ai#6599), may not be partic…
f4901d6 
…ularly precise
@nailiable
feat(breadcrumb-item): add slots type (tusen-ai#6599)
aa30016
@nailiable
feat(breadcrumb-item): export slots type (tusen-ai#6599)
93fd985
@nailiable
feat(button): add slots type (tusen-ai#6599)
1ef779c
@nailiable
feat(calendar): add slots type (tusen-ai#6599)
f1eb605
@nailiable
feat(card): add slots type (tusen-ai#6599)
afcb2dc
@nailiable
feat(carousel): add slots type (tusen-ai#6599)
14b2a52
@nailiable
feat(cascader): add slots type (tusen-ai#6599)
b09b168
@nailiable
feat(collapse): add slots type (tusen-ai#6599)
e3ab2bb
@nailiable
feat(color-picker): add slots type (tusen-ai#6599)
5df707c
@nailiable
feat(data-table): add slots type (tusen-ai#6599)
4cfb159
@nailiable
feat(date-picker): add slots type (tusen-ai#6599)
bbe901d
@nailiable
feat(descriptions): add slots type (tusen-ai#6599)
0139b74
@nailiable
feat(dialog): add slots type (tusen-ai#6599)
26e6ded
@nailiable
feat(drawer-content): add slots type (tusen-ai#6599)
f86adc3
@nailiable
feat(dynamic-input): add slots type (tusen-ai#6599)
373732c
@nailiable
feat(dynamic-tags): add slots type (tusen-ai#6599)
e5fab2c
@nailiable
feat(ellipsis): add slots type (tusen-ai#6599)
fa678e3
@nailiable
feat(empty): add slots type (tusen-ai#6599)
acdc030
@nailiable
feat(float-button): add slots type (tusen-ai#6599)
d12a62f
@nailiable
feat(image): add slots type (tusen-ai#6599)
c30d73d
@nailiable
feat(input): add slots type (tusen-ai#6599)
0c1b522
@nailiable
feat(input-number): add slots type (tusen-ai#6599)
83d9bc5
@nailiable
feat(list): add slots type (tusen-ai#6599)
8b0c79d
@nailiable
feat(mention): add slots type (tusen-ai#6599)
bad51fd
@nailiable
feat(popselect): add slots type (tusen-ai#6599)
a0223dc
@nailiable
feat(result): add slots type (tusen-ai#6599)
6fd2272
@nailiable
feat(select): add slots type (tusen-ai#6599)
1d69061
@nailiable
feat(slider): add slots type (tusen-ai#6599)
040600b
@nailiable
feat(spin): add slots type (tusen-ai#6599)
6e06edf
@nailiable
feat(split): add slots type (tusen-ai#6599)
318ec6f
@nailiable
feat(statistic): add slots type (tusen-ai#6599)
f4220cf
@nailiable
feat(step): add slots type (tusen-ai#6599)
be2d9d5
@nailiable
feat(switch): add slots type (tusen-ai#6599)
7dd15f0
@nailiable
feat(tabs): add slots type (tusen-ai#6599)
a27a085
@nailiable
feat(tag): add slots type (tusen-ai#6599)
968ac46
@nailiable
feat(thing): add slots type (tusen-ai#6599)
30ffd0a
@nailiable
feat(time-picker): add slots type (tusen-ai#6599)
63c92b2
@nailiable
feat(time-picker): export slots type (tusen-ai#6599)
b18dc5e
@nailiable
feat(timeline): export slots type (tusen-ai#6599)
105c873
@nailiable
feat(tooltip): export slots type (tusen-ai#6599)
90624f1
@nailiable
feat(tree): export slots type (tusen-ai#6599)
45366cb
@nailiable
feat(tree-select): export slots type (tusen-ai#6599)
b9f0b9f
@nailiable
feat(upload-trigger): export slots type (tusen-ai#6599)
41ad866
@vercel Vercel
Copy link

vercel bot commented Dec 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
naive-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2024 4:37pm

@Groupguanfang Groupguanfang changed the title feat: add slots typing for all components feat: add slots typing for all components #6599 Dec 7, 2024
@Groupguanfang
Copy link
Author

Related #6599

@Groupguanfang Groupguanfang changed the title feat: add slots typing for all components #6599 feat: add slots typing for all components Dec 7, 2024
@jahnli
Copy link
Collaborator

jahnli commented Dec 8, 2024

👍

@Groupguanfang
Copy link
Author

什么时候发新版本，merge一下
之前就是因为没有slot的类型提示，导致有一次slot名称拼错了，死活找不着原因
能不能快点发新版合并？

@jahnli
Copy link
Collaborator

jahnli commented Dec 9, 2024

什么时候发新版本，merge一下 之前就是因为没有slot的类型提示，导致有一次slot名称拼错了，死活找不着原因 能不能快点发新版合并？

圈下作者吧，让他空的时候 merge 下

@Groupguanfang
Copy link
Author

@07akioni 看一下这个🙏🎈

@Nakus0426
Copy link
Contributor

@07akioni 牢大，这个pr真的很有用

@Groupguanfang
Copy link
Author

@07akioni 牢大，求求了🥺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

能否支持slot的类型？
4 participants
@Groupguanfang @jahnli @Nakus0426 @nailiable