Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start simulation when launching Ignition #83

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Start simulation when launching Ignition #83

merged 1 commit into from
Oct 9, 2024

Conversation

fdila
Copy link
Contributor

@fdila fdila commented Sep 27, 2024 •
edited
Loading

Description

Make Ignition start the simulation when it is launched.

This seems to fix issue #81

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested locally on my laptop, with ROS Humble and Ubuntu 22.04

# Run this command
ros2 launch turtlebot4_ignition_bringup turtlebot4_ignition.launch.py

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@fdila fdila requested a review from hilary-luo as a code owner September 27, 2024 09:01
@JohannesH1998
Copy link

i can confirm that this fixes issue #81

@kscottz kscottz merged commit 12f8f9e into turtlebot:humble Oct 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hilary-luo hilary-luo Awaiting requested review from hilary-luo hilary-luo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fdila @JohannesH1998 @kscottz