Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated links #70

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Update deprecated links #70

merged 2 commits into from
Apr 11, 2024

Conversation

hilary-luo
Copy link
Contributor

@hilary-luo hilary-luo commented Mar 26, 2024

Description

Updates deprecated links to get rid of warnings and commented out models that are currently broken on the fuel server (redirects are currently broken but those models use the deprecated links within the model itself which we cannot fix).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Deleted all downloaded fuel server models and then launched the simulation in both warehouse and depot worlds.

# Run this command
ros2 launch turtlebot4_ignition_bringup ignition.launch.py
ros2 launch turtlebot4_ignition_bringup ignition.launch.py world:=depot

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@WallerJonathan
Copy link

Has this problem been solved yet? I tried changing the uri's to gazebosim.org as is seen in the commits, and gazebo opens but neither warehouse nor depot load in.

@hilary-luo hilary-luo marked this pull request as ready for review April 11, 2024 18:40
@hilary-luo hilary-luo requested a review from roni-kreinin April 11, 2024 18:40
@hilary-luo
Copy link
Contributor Author

@WallerJonathan The current status of this branch should work for loading the warehouse (assuming that you are not running into the other open issue). In regards to the depot, that is being tracked here: #73

@hilary-luo hilary-luo merged commit 0c304e9 into humble Apr 11, 2024
2 checks passed
@hilary-luo hilary-luo deleted the hluo/gazebo-link-update branch April 11, 2024 21:08
@JHPHELAN
Copy link

Do the fixes apply to the Debian package or only from source?

@hilary-luo
Copy link
Contributor Author

@JHPHELAN currently from source and it will be available from Debian on the ros package server when the ros packages get synced. You can generally find info about syncs on discourse although be aware that it is done on a per distro basis. This is not something that I have any control over.

Be aware that this is only for Humble. Galactic will not receive an update for source builds and packages are not synced for Galactic since the distro is end of life.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants