Fixes [Bug]: Incorrect connection creation #4 #13

ineersa · 2024-07-10T19:14:01Z

PR #5 got messed up after merges.
Fixed issues, tested that it's working.

# Conflicts: # src/Database/LibSQLConnectionFactory.php

ineersa · 2024-07-10T19:16:22Z

src/Database/LibSQLConnection.php

@@ -30,33 +31,6 @@ public function sync(): void
        $this->db->sync();
    }

-    public function getDb(): LibSQL


@darkterminal As we were talking #5 (comment)

I don't think it's good idea to have this methods, because they are ambiguous.

Would it be better if this were reserved for internal derivatives only?

You can already access $this->db, and even tho, since it's actually public it's not reserved for internal usage only, maybe it would be better to set it to protected.

Make sense... the property are need to be protected.

ineersa · 2024-07-10T19:18:47Z

src/Database/LibSQLConnection.php

-        return $this->db->getConnectionMode();
-    }
-
-    public function statement($query, $bindings = []): bool


Why are you removing actual implementation?

/** * Execute an SQL statement and return the boolean result. * * @param string $query * @param array $bindings * @return bool */ public function statement($query, $bindings = []) { return $this->run($query, $bindings, function ($query, $bindings) { if ($this->pretending()) { return true; } $statement = $this->getPdo()->prepare($query); $this->bindValues($statement, $this->prepareBindings($bindings)); $this->recordsHaveBeenModified(); return $statement->execute(); }); }

This will totally mess up things further, especially if you will work with models inserts/updates.

I had to lie with this to the Connection class:

public function getDb(): LibSQL { return $this->db->getDb(); } public function getConnectionMode(): string { return $this->db->getConnectionMode(); } public function statement($query, $bindings = []): bool { $res = $this->select($query, $bindings); return !empty($res); } public function getPdo(): LibSQLDatabase { return $this->db; } public function getReadPdo(): LibSQLDatabase { return $this->db; } public function select($query, $bindings = [], $useReadPdo = true) { $result = (array) parent::select($query, $bindings, $useReadPdo); $resultArray = array_map(function ($item) { return (array) $item; }, $result); return $resultArray; }

Because when I used this method:

/** * Execute an SQL statement and return the boolean result. * * @param string $query * @param array $bindings * @return bool */ public function statement($query, $bindings = []) { return $this->run($query, $bindings, function ($query, $bindings) { if ($this->pretending()) { return true; } $statement = $this->getPdo()->prepare($query); $this->bindValues($statement, $this->prepareBindings($bindings)); $this->recordsHaveBeenModified(); return $statement->execute(); }); }

Database connections will use the PDO engine to perform binding, whereas libSQL itself does not have natural binding parameters like PDO.

Database connections will use the PDO engine to perform binding, whereas libSQL itself does not have natural binding parameters like PDO.

Yes, that's right, and you are rewriting it inside your Statement class, method execute.

On my dev branch I've changed structure a little, to make concerns for statement/connection classes more clear.
main...ineersa:turso-driver-laravel:dev-branch

Primary I done that to address issue with lastInsertId which was not working and was implemented in the wrong place, and it's actually crucial for Eloquent models.

Also I have some strange problems with bindings on INSERT currently, where TEXT column data is truncated.

But if you will try and look into my dev branch, you can see that everything is working via base methods.

Yea problem is more fundamental, and lies in internal not compatibility between this implementation and PDO classes.
#14 this one has roots from there also, I will try to look at it on the next week

So, now it's clearer why I made a lot of unconventional things with this package.

And for reason about the connection string need to follow the Turso conventional, because the binary itself is have a logic to identifying the connection mode like this:

pub fn get_mode( url: Option<String>, auth_token: Option<String>, sync_url: Option<String>, ) -> String { match (url, auth_token, sync_url) { (Some(ref url), Some(ref auth_token), Some(ref sync_url)) if (url.starts_with("file:") || url.ends_with(".db") || url.starts_with("libsql:")) && !auth_token.is_empty() && (sync_url.starts_with("libsql://") || sync_url.starts_with("http://") || sync_url.starts_with("https://")) => { "remote_replica".to_string() } (Some(ref url), Some(ref auth_token), _) if !auth_token.is_empty() && url.starts_with("libsql://") || url.starts_with("http://") || url.starts_with("https://") => { "remote".to_string() } (Some(ref url), _, _) if url.starts_with("file:") || url.ends_with(".db") || url.starts_with("libsql:") || url.contains(":memory:") => { "local".to_string() } _ => "Mode is not available!".to_string(), } }

Check if is Remote Replica Connection?

url starts with file:, ends with .db, or starts with libsql:.

auth_token is not empty.

sync_url starts with libsql://, http://, or https://.

Check if is Remote Connection?

auth_token is not empty.

url starts with libsql://, http://, or https://.

Check if is Local Connection?

url starts with file:, ends with .db, starts with libsql:, or contains :memory:.

Yea problem is more fundamental, and lies in internal not compatibility between this implementation and PDO classes.

Please remember, the real challenge is to make it compatible without using PDO. So far what I've done is freestyle which may look very strange.

src/Database/LibSQLConnection.php

ineersa · 2024-07-10T19:20:45Z

src/Database/LibSQLConnection.php

@@ -88,16 +69,6 @@ public function useDefaultSchemaGrammar()
        }
    }

-    public function createReadPdo(array $config): ?LibSQLDatabase


Again, createReadPdo() is used only in ConnectionFactory, which we are not using, and it's ConnectionFactory method, not connection.

src/Database/LibSQLConnection.php

src/Database/LibSQLDatabase.php

darkterminal · 2024-07-13T21:45:32Z

Hi @ineersa, I just made a major change to libSQLConnection to change all database transaction related operations that used PDO to now use LibSQL and I kept the LibSQLConnectionFactory to register the new driver database.

You can try it and I would like to know how it turned out from your side.

ineersa · 2024-07-17T18:02:49Z

Hi @ineersa, I just made a major change to libSQLConnection to change all database transaction related operations that used PDO to now use LibSQL and I kept the LibSQLConnectionFactory to register the new driver database.

You can try it and I would like to know how it turned out from your side.

@darkterminal
I've moved part which adds testing into separate PR - https://github.com/tursodatabase/turso-driver-laravel/pull/15/files#diff-0755941eb5e1efaa30f08d0ea030c92b47b4d4974e93967e9d446e9f3e7e22d9R26

Some of the connection methods are working now on main like https://github.com/tursodatabase/turso-driver-laravel/pull/15/files#diff-0755941eb5e1efaa30f08d0ea030c92b47b4d4974e93967e9d446e9f3e7e22d9R59 local file for example

Some of them are not - https://github.com/tursodatabase/turso-driver-laravel/pull/15/files#diff-0755941eb5e1efaa30f08d0ea030c92b47b4d4974e93967e9d446e9f3e7e22d9R26 like memory for example.

I've tried to follow README.md, so if you tested your changes and they were working, please update documentation with correct setup for each connection type and add tests for those connection types.

This PR has also some tests in this regard but they are using default Laravel way of database connection definition - https://github.com/tursodatabase/turso-driver-laravel/pull/13/files#diff-0755941eb5e1efaa30f08d0ea030c92b47b4d4974e93967e9d446e9f3e7e22d9

darkterminal · 2024-07-17T20:58:51Z

@ineersa I will update the README follow the tests that I already merged. test-feature are passed!

But, the escapeString and quote in LibSQLConnection is still error in the test:

tonysm · 2024-10-21T14:08:11Z

Folks, any chance of getting this merged? I'm working on an app that deals with multiple connections (multiple libsql connections but also non-libsql connections), so I think this patch is on the right direction, right?

ineersa · 2024-10-21T14:32:54Z

Folks, any chance of getting this merged? I'm working on an app that deals with multiple connections (multiple libsql connections but also non-libsql connections), so I think this patch is on the right direction, right?

I doubt, there was too much changes at time of this PR, so it would be better to revisit it with current driver version.
Root causes of problems with multiple connections was fixed here yes, but there was too much things not working, so i gave up and went to SQLite. Might get back to this when will have more time.

tonysm · 2024-10-21T15:04:50Z

@ineersa Thanks for the heads up and for the work on this one so far! Being limited to a single connection is a bummer. Not sure how to overcome that for the app I'm working on. But thanks!

ineersa and others added 15 commits July 5, 2024 10:12

Fixing connection

20de144

Fixing tests

0e9ca74

Lint

f147c87

Fixed getName()

a02cd06

added closure

99a7d2f

Fixing connection

cfd7da3

Fixing tests

75d6e53

Lint

ecc333f

Fixed getName()

f2d4614

added closure

a381c8c

Merge remote-tracking branch 'origin/fix-connection' into fix-connection

672642f

Merge branch 'fix-grammar' into fix-connection

5a76091

Merge branch 'main' into fix-connection

e73345b

Merge remote-tracking branch 'origin/main' into fix-connection

757c631

# Conflicts: # src/Database/LibSQLConnectionFactory.php

changes after merge

40be2f2

ineersa commented Jul 10, 2024

View reviewed changes

ineersa and others added 2 commits July 12, 2024 12:15

Merge branch 'main' into fix-connection

cfafa04

Merge branch 'main' into fix-connection

d0be473

darkterminal mentioned this pull request Jul 18, 2024

[Bug]: String quoting #10

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes [Bug]: Incorrect connection creation #4 #13

Fixes [Bug]: Incorrect connection creation #4 #13

ineersa commented Jul 10, 2024

ineersa Jul 10, 2024

darkterminal Jul 12, 2024

ineersa Jul 12, 2024

darkterminal Jul 13, 2024

ineersa Jul 10, 2024

darkterminal Jul 12, 2024

ineersa Jul 12, 2024

ineersa Jul 12, 2024

darkterminal Jul 13, 2024

darkterminal Jul 13, 2024

ineersa Jul 10, 2024

darkterminal commented Jul 13, 2024

ineersa commented Jul 17, 2024

darkterminal commented Jul 17, 2024 •

edited

Loading

tonysm commented Oct 21, 2024

ineersa commented Oct 21, 2024

tonysm commented Oct 21, 2024

Fixes [Bug]: Incorrect connection creation #4 #13

Are you sure you want to change the base?

Fixes [Bug]: Incorrect connection creation #4 #13

Conversation

ineersa commented Jul 10, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

darkterminal commented Jul 13, 2024

ineersa commented Jul 17, 2024

darkterminal commented Jul 17, 2024 • edited Loading

tonysm commented Oct 21, 2024

ineersa commented Oct 21, 2024

tonysm commented Oct 21, 2024

darkterminal commented Jul 17, 2024 •

edited

Loading