Open
Conversation
Author
|
83dece2 to
6a77c34
Compare
ef8454b to
06b7515
Compare
Author
|
Hey @penberg, can you please check the pr? |
…ase#232) - Add snapshot() method to AgentFS SDK using checkpoint + file copy - Add 'agentfs snapshot' CLI command for manual snapshots - Add automatic snapshot on nested 'agentfs run' (detected via AGENTFS_SESSION env var) - Add Snapshot error variant - Add tests for snapshot functionality
06b7515 to
9819bff
Compare
Collaborator
Author
|
Hi @penberg, thanks for the feedback! You're right - the current implementation has a race window between the WAL checkpoint and file copy where concurrent writes could slip through. I noted this limitation when implementing it. A few questions:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #57, #232