CharacterController has allowGod option

[ghost]

No description provided.

[ianballantyne]

Seems like a fair addition. Please can you make the following changes:

1. Setting the params.allowGod = false, appears to still allow god mode
2. Can you change the '{' bracket of the setGod function to be on the next line to match the Turbulenz style guidelines.
   Thanks for contributing!

[ghost]

I don't get the 1.

Ian Ballantyne wrote:

Seems like a fair addition. Please can you make the following changes:

1. Setting the params.allowGod = false, appears to still allow god mode
2. Can you change the '{' bracket of the setGod function to be on the
   next line to match the Turbulenz style guidelines.
   Thanks for contributing!

—
Reply to this email directly or view it on GitHub
#31 (comment).

[ianballantyne]

c.allowGod = params.allowGod || c.allowGod;

in this case if params.allowGod is false (or undefined), then allowGod will still be true. It should probably be:

if (params.allowGod !== undefined)
{
c.allowGod = params.allowGod;
}

[ghost]

Oh... yes.

Ian Ballantyne wrote:

c.allowGod = params.allowGod || c.allowGod;

in this case if params.allowGod is false (or undefined), then allowGod
will still be true. It should probably be:

if (params.allowGod !== undefined)
{
c.allowGod = params.allowGod;
}

—
Reply to this email directly or view it on GitHub
#31 (comment).

[ghost]

fixed

[ghost]

@ianballantyne I fixed your two points.

[ianballantyne]

@Herby Thanks. We'll take a look shortly.

[davidgaleano]

I would suggest to change the option to be "disableGod", it makes the logic a bit simpler.

[ghost]

done

David Galeano wrote:

I would suggest to change the option to be "disableGod", it makes the
logic a bit simpler.

—
Reply to this email directly or view it on GitHub
#31 (comment).

[davidgaleano]

We usually write line 149 like this:

    c.disableGod = params.disableGod || false;

[ghost]

Whatever you see fit.

David Galeano wrote:

We usually write line 149 like this:

| c.disableGod = params.disableGod || false;
|

—
Reply to this email directly or view it on GitHub
#31 (comment).