Skip to content

Conversation

@JayRovacsek
Copy link

As per #530 the team table is broken

Please note that I recognise the removal of these fields is a worst-case scenario for consumers of this field. I have not deeply investigated if these fields could be reimplemented, the changelog upstream that introduced the issue only removes the fields and there may be other graph entities that can be hydrated from that would re-enable these fields in the github_team table. At current time, it appears all calls to github_team are failing due to this however.

Utilised test sql is:

select
    combined_slug,
    created_at,
    description,
    id,
    name,
    organization,
    parent_team,
    privacy,
    slug,
    updated_at
from
    github_team
where organization = 'acme'
limit 10

Results before applying the changes in this PR:

Error: github: Field 'discussionsUrl' doesn't exist on type 'Team' (SQLSTATE HV000)

+---------------+------------+-------------+----+------+--------------+-------------+---------+------+------------+
| combined_slug | created_at | description | id | name | organization | parent_team | privacy | slug | updated_at |
+---------------+------------+-------------+----+------+--------------+-------------+---------+------+------------+
+---------------+------------+-------------+----+------+--------------+-------------+---------+------+------------+

After applying changes in this PR: (redacted values)

+-----------------------------+---------------------------+--------------------------------------------------+------------+-------------------+--------------+------------------------------------------------------------------------------------------+---------+-------------------+---------------------------+
| combined_slug               | created_at                | description                                      | id         | name              | organization | parent_team                                                                              | privacy | slug              | updated_at                |
+-----------------------------+---------------------------+--------------------------------------------------+------------+-------------------+--------------+------------------------------------------------------------------------------------------+---------+-------------------+---------------------------+
| acme/acme | 2023-11-17T09:06:59+11:00 | ACME                       | 1  | ACME | ACME    | {"id":1,"name":"acme","node_id":"acme","slug":"acme"}      | VISIBLE | acme | 1970-01-01T00:00:00 |

@JayRovacsek JayRovacsek changed the title DRAFT | fix: address removed attribute on team table fix: address removed attributes on team table Jan 16, 2026
@JayRovacsek
Copy link
Author

@misraved @khushboo9024 apologies to tag you on this, I might have missed the methodology to request a review 🙏😁

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a critical breaking change in GitHub's GraphQL API (effective 2026-01-08) where the discussionsUrl field and discussions collection were removed from the Team type, causing all queries to the github_team table to fail with a "Field 'discussionsUrl' doesn't exist on type 'Team'" error.

Changes:

  • Removed the deprecated discussions_url and discussions_total_count columns from the team table
  • Cleaned up associated GraphQL field mappings, hydration functions, and model struct fields

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
github/models/team.go Removed DiscussionsUrl field from Team struct and Discussions field from TeamWithCounts struct to align with GitHub GraphQL API changes
github/team_utils.go Removed column includes and hydration functions for discussions_url and discussions_total_count
github/table_github_team.go Removed discussions_url and discussions_total_count column definitions from the team table schema

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant