-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added public ip doc. #13
base: main
Are you sure you want to change the base?
Conversation
@@ -18,6 +18,7 @@ You must be assigned the tenant or organization **Owner** role to create, modify | |||
## Related links: | |||
| | | | | |||
| ------ | ------------- | ------------- | | |||
| Public IP Addresses | [Docs](https://turbot.com/pipes/docs/integrations/public-ip) | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try moving this to Reference
-> Public IP Addresses
?
@johnsmyth thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree @MichaelBurgess - I would put it in the reference section somewhere
docs/integrations/public-ip.md
Outdated
@@ -0,0 +1,25 @@ | |||
# Pipes' Public IP Addresses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're already in the Pipes docs, do we need Pipes'
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it wasn't necessary, removed Pipes'
docs/integrations/public-ip.md
Outdated
# Pipes' Public IP Addresses | ||
|
||
## **Overview** | ||
This document provides a list of public IPs used by Pipes for outbound requests. These IPs are intended for end-users to configure whitelisting, firewall rules, and integrations with external services. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these for inbound, outbound or both?
Also, would just be end users
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the ips are for both inbound and outbound requests, fixed it. Also changed end-users
to end users
docs/integrations/public-ip.md
Outdated
|
||
| **Load Balancer Name** | **Static IP Address** | **Ports** | | ||
|------------------------------|---------------------------|---------------| | ||
| Main Service | 34.86.218.179 | 80, 443 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is Main Service
? Is this API, or something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah! This is the main load balancer that redirects traffic from our application url to our services.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a better name than Main Service
?
docs/integrations/public-ip.md
Outdated
| **Load Balancer Name** | **Static IP Address** | **Ports** | | ||
|------------------------------|---------------------------|---------------| | ||
| Main Service | 34.86.218.179 | 80, 443 | | ||
| Database Proxy | 34.145.175.31 | 9193 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably best to be more Pipe-specific? Steampipe DB
or Steampipe DB Proxy
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Updated to Steampipe Database
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The DB and dashboard IPs are really per hive; we just happen to only have one hive at present. It may be more accurate to look them up for your individual workspace. For example, you can get your database host from the Steampipe query tab by clicking the info button, eg, myorg-workspace.usea1.db.pipes.turbot.com
. The dashboard endpoint is the same as the db, replacing the .db
segment with .dashboard
, eg myorg-workspace.usea1.dashboard.pipes.turbot.com
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not call these "load balancer IPs" - that's not really relevant to the end user. Note that the scope is different - what you call Application Endpoint is the pipes.turbot.com console and API endpoint, and it's global for everyone. Steampipe Database and Powerpipe Dashboard are for your workspace and could vary from one workspace to the next (eventually).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prithage perhaps have a chat with @johnsmyth on this to get the required path for updates?
docs/integrations/public-ip.md
Outdated
|------------------------------|---------------------------|---------------| | ||
| Main Service | 34.86.218.179 | 80, 443 | | ||
| Database Proxy | 34.145.175.31 | 9193 | | ||
| Dashboard | 34.85.232.246 | 80, 443 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above - Powerpipe Dashboard
or Powerpipe Dashboard Proxy
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to Powerpipe Dashboard
docs/integrations/public-ip.md
Outdated
#### **1. Load Balancer IPs** | ||
The following IPs are used by Pipes' load balancers. Please ensure these are whitelisted for access to our services: | ||
|
||
| **Load Balancer Name** | **Static IP Address** | **Ports** | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comments:
- Should these be /32 CIDRs?
- Please line up the markdown across the row cols
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General practice is to use /32 so updated the doc with the same.
No description provided.