Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup.py for easy installation #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add setup.py for easy installation #4

wants to merge 2 commits into from

Conversation

jr-42
Copy link

@jr-42 jr-42 commented May 27, 2021

Added a setup.py and requirements in order to be able to install locally.
Included changes to ficus code from PR #3

@ntropy-esa
Copy link

Should there be a version requirement on pyomo?

Three years ago, I used to work with pyomo 5.6.1 which no longer works unless we explicitly revert also to PyUtilib=5.6.5
"ImportError: pyutilib.enum has been removed.
Python 3 now has an enum implementation in the standard library (also
available for older Python versions as the third-party enum34 PyPI
package) that supersedes this library."

Working with a newer version of pyomo=5.7.3, there would be bugs in writing the report files in Excel (functions report(prob, result_dir) & get_entities & _get_onset_names ), because of pyomo related changes (some domain name are 'Any' instead of 'None', which bugged an if statement in ficus's code).

And I also got issues related to xlrd and openpyxel (empty dataframes not handled in the same way).

Lasty, changes in pandas: as_matrix can be replaced by to_numpy

@jr-42
Copy link
Author

jr-42 commented Jun 1, 2021

I came across this Pyomo error with the 'Any's and the 'None'. I did a little workaround in the if loop but I will test if changing the version of pyomo works.

Will change as_matrix to to_numpy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants