Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix max call stack error #1723

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix max call stack error #1723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
343da45
fix max call stack error
sandeepkumarcel Nov 20, 2024
10509cb
lint
sandeepkumarcel Nov 21, 2024
0f475e2
update docker version
sandeepkumarcel Nov 21, 2024
540bf18
more docker compose updates
sandeepkumarcel Nov 21, 2024
c28c987
update
sandeepkumarcel Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ jobs:
displayName: should skip tests
- bash: test $SKIP_TESTS && echo "Skipped!" || yarn install
displayName: yarn install
- bash: test $SKIP_TESTS && echo "Skipped!" || docker-compose -f ${COMPOSE_FILE} pull
displayName: docker-compose pull
- bash: test $SKIP_TESTS && echo "Skipped!" || docker compose -f ${COMPOSE_FILE} pull
displayName: docker compose pull
- bash: test $SKIP_TESTS && echo "Skipped!" || yarn test:group:broker:ci
displayName: test
- task: PublishTestResults@2
Expand All @@ -94,8 +94,8 @@ jobs:
displayName: should skip tests
- bash: test $SKIP_TESTS && echo "Skipped!" || yarn install
displayName: yarn install
- bash: test $SKIP_TESTS && echo "Skipped!" || docker-compose -f ${COMPOSE_FILE} pull
displayName: docker-compose pull
- bash: test $SKIP_TESTS && echo "Skipped!" || docker compose -f ${COMPOSE_FILE} pull
displayName: docker compose pull
- bash: test $SKIP_TESTS && echo "Skipped!" || yarn test:group:admin:ci
displayName: test
- task: PublishTestResults@2
Expand All @@ -119,8 +119,8 @@ jobs:
displayName: should skip tests
- bash: test $SKIP_TESTS && echo "Skipped!" || yarn install
displayName: yarn install
- bash: test $SKIP_TESTS && echo "Skipped!" || docker-compose -f ${COMPOSE_FILE} pull
displayName: docker-compose pull
- bash: test $SKIP_TESTS && echo "Skipped!" || docker compose -f ${COMPOSE_FILE} pull
displayName: docker compose pull
- bash: test $SKIP_TESTS && echo "Skipped!" || yarn test:group:producer:ci
displayName: test
- task: PublishTestResults@2
Expand All @@ -144,8 +144,8 @@ jobs:
displayName: should skip tests
- bash: test $SKIP_TESTS && echo "Skipped!" || yarn install
displayName: yarn install
- bash: test $SKIP_TESTS && echo "Skipped!" || docker-compose -f ${COMPOSE_FILE} pull
displayName: docker-compose pull
- bash: test $SKIP_TESTS && echo "Skipped!" || docker compose -f ${COMPOSE_FILE} pull
displayName: docker compose pull
- bash: test $SKIP_TESTS && echo "Skipped!" || yarn test:group:consumer:ci
displayName: test
env:
Expand All @@ -171,8 +171,8 @@ jobs:
displayName: should skip tests
- bash: test $SKIP_TESTS && echo "Skipped!" || yarn install
displayName: yarn install
- bash: test $SKIP_TESTS && echo "Skipped!" || docker-compose -f ${COMPOSE_FILE} pull
displayName: docker-compose pull
- bash: test $SKIP_TESTS && echo "Skipped!" || docker compose -f ${COMPOSE_FILE} pull
displayName: docker compose pull
- bash: test $SKIP_TESTS && echo "Skipped!" || yarn test:group:others:ci
displayName: test
- task: PublishTestResults@2
Expand All @@ -199,8 +199,8 @@ jobs:
displayName: should skip tests
- bash: test $SKIP_TESTS && echo "Skipped!" || yarn install
displayName: yarn install
- bash: test $SKIP_TESTS && echo "Skipped!" || docker-compose -f ${COMPOSE_FILE} pull
displayName: docker-compose pull
- bash: test $SKIP_TESTS && echo "Skipped!" || docker compose -f ${COMPOSE_FILE} pull
displayName: docker compose pull
- bash: test $SKIP_TESTS && echo "Skipped!" || yarn test:group:oauthbearer:ci
displayName: test
- task: PublishTestResults@2
Expand Down
4 changes: 2 additions & 2 deletions scripts/dockerComposeUp.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
COMPOSE_FILE=${COMPOSE_FILE:="docker-compose.2_4.yml"}

echo "Running compose file: ${COMPOSE_FILE}:"
docker-compose -f "${COMPOSE_FILE}" up --force-recreate -d
docker compose -f "${COMPOSE_FILE}" up --force-recreate -d
if [ -z ${NO_LOGS} ]; then
docker-compose -f "${COMPOSE_FILE}" logs -f
docker compose -f "${COMPOSE_FILE}" logs -f
fi
4 changes: 2 additions & 2 deletions scripts/testWithKafka.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ find_container_id() {
}

quit() {
docker-compose -f "${COMPOSE_FILE}" down --remove-orphans
docker compose -f "${COMPOSE_FILE}" down --remove-orphans
exit 1
}

Expand Down Expand Up @@ -51,6 +51,6 @@ TEST_EXIT=$?
echo

if [ -z ${DO_NOT_STOP} ]; then
docker-compose -f "${COMPOSE_FILE}" down --remove-orphans
docker compose -f "${COMPOSE_FILE}" down --remove-orphans
fi
exit ${TEST_EXIT}
2 changes: 1 addition & 1 deletion scripts/waitForKafka.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ waitForNode(kafka3ContainerId)
console.log('\nAll nodes up:')
console.log(
execa
.commandSync(`docker-compose -f ${process.env.COMPOSE_FILE} ps`, { shell: true })
.commandSync(`docker compose -f ${process.env.COMPOSE_FILE} ps`, { shell: true })
.stdout.toString('utf-8')
)

Expand Down
4 changes: 3 additions & 1 deletion src/protocol/requests/fetch/v4/decodeMessages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ const decodeMessages = async decoder => {
while (messagesDecoder.canReadBytes(RECORD_BATCH_OVERHEAD)) {
try {
const recordBatch = await RecordBatchDecoder(messagesDecoder)
records.push(...recordBatch.records)
for (let i = 0; i < recordBatch.records.length; i++) {
records.push(recordBatch.records[i])
}
} catch (e) {
// The tail of the record batches can have incomplete records
// due to how maxBytes works. See https://cwiki.apache.org/confluence/display/KAFKA/A+Guide+To+The+Kafka+Protocol#AGuideToTheKafkaProtocol-FetchAPI
Expand Down