Implement static membership feature on client side (KIP-345) #1594
Conversation
implement kip-345 add test fixtures ts-defs
| @@ -12,6 +12,8 @@ const ResourcePatternTypes = require('./src/protocol/resourcePatternTypes') | |||
| const { isRebalancing, isKafkaJSError, ...errors } = require('./src/errors') | |||
| const { LEVELS } = require('./src/loggers') | |||
|
|
|||
| // local two | |||
|
This is exciting work! It seems like this has also implemented most of (all of?) KIP-320. Can you help me understand what parts of Nevon's earlier checklist might still be left to complete?
I'd love to help get this over the line. |
|
can we advance this pr? |
|
This feature will be very helpful in our case. |
|
Same here, this is really useful. |
|
This pr will help us a lot |
|
Agree, that this feature will help many developers |
|
Please don't delay this pr. I need it |
|
+1, would help a lot with a current project |
| if (memberId) { | ||
| await this.coordinator.leaveGroup({ groupId, memberId }) | ||
| await this.coordinator.leaveGroup({ groupId, memberId, groupInstanceId }) |
There was a problem hiding this comment.
We should not send leave group if static membership is enabled, i.e groupInstancId is defined.
There was a problem hiding this comment.
Can't you change it yourself? We're just waiting for this feature and no one is reacting!
There was a problem hiding this comment.
@abbccdda It is not necessary that anybody who uses static membership would never want to stop the graceful termination of consumption. This is a valid change. If one does not want to call leave group then just have to not call the consumer.stop() & consumer.disconnect() & leave group won't be called.
There was a problem hiding this comment.
Hey it seems like a lot of people are waiting for this (including me). I'd be willing to take this on since it seems like it's so close to being done. What's there left to do? Just this?
|
@sandeepkumarcel check please comments, realy waiting for this PR |
|
@sandeepkumarcel have you tested this PR somewhere? if yes, then let us know, at least I am ok to use your forked version in my use case. |
implement kip-345
add test fixtures
ts-defs