-
Notifications
You must be signed in to change notification settings - Fork 20
feat: add mouse tracking support to KeyStrokeListener #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pepicrft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@finnvoor would you mind rebasing the latest changes from main to eliminate some noise from the PR?
|
@all-contributors add @finnvoor for code |
|
I've put up a pull request to add @finnvoor! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're a CLI wizard! 🪄
pepicrft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You blew my mind with this. @finnvoor what if we rename KeystrokeListener to TerminalEventListener to be more generic? Otherwise listening mouse events from a keystroke listener feels odd.
I think that would be nice, in the future it could also send other event types e.g. terminal resize signal |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Pedro <[email protected]>
Co-authored-by: Pedro <[email protected]>
KeyStrokeListenerwithMouseTrackingtoTerminalto enable mouse tracking / mouse motion trackingKeyStrokeListenerTeststo test characters/special keys/mouse events are decoded properlyKeyStrokeListenerdocs describing how to listen for mouse eventsmouse-trackingtoexamples-cliwith a demo showcasing mouse tracking (click and drag to draw). I wasn't sure if this should be included as an example since it does not showcase a specific component, but I think it's a good example demoingKeyStrokeListener. Happy to remove though.A future PR can add mouse support to the existing components (click yes/no, select option from list with mouse)
CleanShot.2025-02-25.at.22.01.33.mp4