various changes to OAI-PMH output for compatibility #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some past commit rebuilt OAI-schema to use dump over load it missed exchanging `pre_load` for `pre_dump` when doing so
martinobersteiner
force-pushed
the
fix/oai-pmh
branch
from
935cac4 to
bee0163
Compare
utnapischtim
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ad
pre_dumpchangeOAISchemais only used in serialization to.dumpdatabase-schemaed json to OAI-schemaed jsonoriginally,
OAISchemaincorrectly used.loadinstead of.dumpthis got changed in this commit
when moving from
.loadto.dump, the commit should also have exchanged the incorrect@pre_loadfor@pre_dump, but didn'tad timezone-unawareness of
now_isoformatdue to issues with timezone-awareness, datetimes are timezone-unaware for now
see here for discussion on this