Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gherkin and add ability to work with multiple languages #128

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

AndreSteenveld
Copy link

  • Gherkin was updated
  • All the projects now target .NET Standard 2.0
  • Gherkin tests in other languages are now possible

Before changing this I want to add a few more tests in emoji-lang to exercise all keywords (examples, rules, etc).

Stuff I've noticed and would like to address:

  • Not all files are consistent with indenting (some are tabbed, some are spaces, some are mixed)
  • Not all files have the same line endings
  • The unit test project has a GherkinFeatureBuilder which isn't used consistently

@AndreSteenveld
Copy link
Author

I'm probably missing something but where can I find the appveyor.yml file? (https://www.appveyor.com/docs/build-configuration/#configuring-build)

@ttutisani
Copy link
Owner

I'm probably missing something but where can I find the appveyor.yml file? (https://www.appveyor.com/docs/build-configuration/#configuring-build)

There is no yml file yet. Everything worked with defaults so far, so the yml file was not necessary. If you need it and know how it works, feel free to create one.

@AndreSteenveld
Copy link
Author

I got appveyor working on my account but don't have access to your account so the builds will fail here until otherwise configured. I commited the appveyor.yml file in the root which seems to work.

@AndreSteenveld AndreSteenveld marked this pull request as ready for review June 30, 2022 14:32
@ttutisani
Copy link
Owner

Sorry, I was in the middle of things. Is this PR ready for review?

@AndreSteenveld
Copy link
Author

Yes, there are a few settings that need tweaking in appveyor settings to make sure it picks up the the yaml file over the settings configured in the GUI. (settings, nuget keys, etc) Other than that I think it is fine. I've produced a local nuget package to keep momentum I've built up in the project I wanted to use this for and so far haven't found issues.

Other than the stuff I mentioned in opening message of this PR I think this is OK. I would like to add a two features in the future;

  • Using named groups to map to a paramater
  • Adding more {...} processors, or at least making it easier to register your own

Should I create a few tickets for those?

@ttutisani
Copy link
Owner

Yes, please create the issue tickets for each request separately. Meanwhile, I will review this PR.

Copy link
Owner

@ttutisani ttutisani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Please address the comments and I will review them again. Thanks!

@@ -0,0 +1,3 @@
* text=auto
appveyor.yml eol=lf
.gitattributes eol=lf
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to check if these changes are necessary.

- cmd: >-
dotnet test --nologo --no-restore --configuration Release source\Xunit.Gherkin.Quick.UnitTests\Xunit.Gherkin.Quick.UnitTests.csproj

dotnet test --nologo --no-restore --configuration Release source\Xunit.Gherkin.Quick.ProjectConsumer\Xunit.Gherkin.Quick.ProjectConsumer.csproj
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. How is this different from what the appveyor does by default?

[FeatureFile("./Addition_ForMultipleUseCases/AddTwoNumbers.feature")]
public sealed partial class AddTwoNumbers : Feature
public partial class AddTwoNumbers : Feature
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why partial?


📕: Scenario Before and After
😐 first step executed
😂 second step executed
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you have added an emoji version for every test. I think that's too much for one feature, otherwise the codebase will grow exponentially and maintenance will be a headache. Please remove all these new feature files for emoji. Just create one feature file and one feature class for emoji version and that will prove the point. You can make that feature as advanced as you can, but keep everything in one feature. I will not be reviewing so many files for the same thing.

source/Xunit.Gherkin.Quick/CoreModel/GherkinDialect.cs Outdated Show resolved Hide resolved
source/Xunit.Gherkin.Quick/Xunit.Gherkin.Quick.csproj Outdated Show resolved Hide resolved
@AndreSteenveld
Copy link
Author

I have been busy and on vacation for the last two weeks so I haven't spent any time on this. Later this week I want to spend some time cleaning up the emoji feature files and making sure there is a relatively complete feature to test with emoji which will hopefully take away most of the noise from the project consumer.

@ttutisani
Copy link
Owner

@AndreSteenveld any news? I haven't heard back from you lately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants