Relace - experimentation #204
Conversation
Himanshu-Singh-Chauhan
requested review from
nang-dev,
Fryingpannn and
a team
as code owners
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to f8ae29a in 1 minute and 29 seconds
More details
- Looked at
291lines of code in6files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. extensions/vscode/src/util/integrationUtils.ts:74
- Draft comment:
TheextractCodeFromMarkdownfunction may not handle multiple code blocks or code blocks without language specification correctly. Consider enhancing the regex to handle these cases. - Reason this comment was not posted:
Confidence changes required:50%
The functionextractCodeFromMarkdownis used to extract code from markdown text. However, the regex used might not cover all edge cases, such as multiple code blocks or code blocks without language specification.
Workflow ID: wflow_zECIHbCaWkYqOSRO
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
core/util/parameters.ts
Outdated
| export const SERVER_URL = "https://stingray-app-gb2an.ondigitalocean.app/pearai-server-api2" | ||
| // export const SERVER_URL = "http://localhost:8000"; | ||
| // export const SERVER_URL = "https://stingray-app-gb2an.ondigitalocean.app/pearai-server-api2" | ||
| export const SERVER_URL = "http://localhost:8000"; |
There was a problem hiding this comment.
Consider using an environment variable for SERVER_URL to allow flexibility between development and production environments.
| @@ -332,6 +333,74 @@ export class VsCodeMessenger { | |||
| verticalDiffManager.streamEdit(prompt, modelTitle); | |||
| }); | |||
|
|
|||
| this.onWebview("applyWithRelace", async (msg) => { | |||
There was a problem hiding this comment.
In applyWithRelace, handle the case where getFastApplyChangesWithRelace returns the original content due to an error. Notify the user that no changes were made.
| ): Promise<string> { | ||
| try { | ||
| const baseHeaders = await getHeaders(); | ||
| const auth: any = await vscode.commands.executeCommand("pearai.getPearAuth"); |
There was a problem hiding this comment.
Avoid using any type for auth. Define a specific type or interface for better type safety.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 4aeb511 in 35 seconds
More details
- Looked at
70lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_NtyzorWOJ1sWCZzF
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| await vscode.commands.executeCommand('workbench.action.revertAndCloseActiveEditor'); | ||
| relaceDiffManager.clearDiffState(); | ||
|
|
||
| this.webviewProtocol.request("setRelaceDiffState", {diffVisible: false, originalFileUri: "aasdfasdf", diffFileUri: "asdfasdf"}); |
There was a problem hiding this comment.
Avoid using placeholder strings like 'aasdfasdf' and 'asdfasdf'. Use meaningful values for the originalFileUri and diffFileUri in the setRelaceDiffState request.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 417dd44 in 39 seconds
More details
- Looked at
281lines of code in3files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. gui/src/components/markdown/CodeBlockToolbar.tsx:170
- Draft comment:
TheacceptRelaceDiffandrejectRelaceDifffunctions are called withundefinedas arguments. Ensure these functions do not rely on parameters that are not being passed, as this could lead to runtime errors. - Reason this comment was not posted:
Comment did not seem useful.
2. core/protocol/ideWebview.ts:22
- Draft comment:
TheacceptRelaceDiffandrejectRelaceDifftypes still includeoriginalFileUrianddiffFileUriparameters, which are no longer used. Consider removing these parameters to align with the updated implementation. - Reason this comment was not posted:
Comment was on unchanged code.
3. extensions/vscode/src/extension/VsCodeMessenger.ts:352
- Draft comment:
Consider showing a user-friendly error message instead of throwing an error whenoriginalContentis not found. This will improve the user experience. - Reason this comment was not posted:
Confidence changes required:50%
TheapplyWithRelacefunction inVsCodeMessenger.tshas a check fororiginalContentbeing empty, but it throws an error instead of showing a user-friendly message. This could be improved for better user experience.
Workflow ID: wflow_eHS2VBtenKRLA6X5
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on f70ebd3 in 47 seconds
More details
- Looked at
210lines of code in4files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. extensions/vscode/src/extension/VsCodeMessenger.ts:727
- Draft comment:
Ensure to handle the case whereverticalDiffManager.createVerticalPerLineDiffHandlerreturnsnullto avoid potential runtime errors. - Reason this comment was not posted:
Comment did not seem useful.
2. extensions/vscode/src/extension/VsCodeMessenger.ts:729
- Draft comment:
Ensure to handle the case whereverticalDiffManager.createVerticalPerLineDiffHandlerreturnsnullto avoid potential runtime errors. - Reason this comment was not posted:
Marked as duplicate.
3. extensions/vscode/src/extension/VsCodeMessenger.ts:681
- Draft comment:
Ensure to handle the case whereverticalDiffManager.createVerticalPerLineDiffHandlerreturnsnullto avoid potential runtime errors. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_ciIBoxaYqbvVABau
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| yield { type: 'new', line: modDiff[diffJ++] }; | ||
| } else if (diffJ >= modDiff.length) { | ||
| // Add CodeLens for deleted line | ||
| vscode.languages.registerCodeLensProvider({ scheme: 'file' }, { |
There was a problem hiding this comment.
Registering a CodeLens provider inside the generator function for each deleted line is inefficient. Consider moving this logic outside the generator to avoid performance issues.
|
this is a good pr to refer to for relace and diff stuff. |
closing this pr, we now have relace, but this is a good pr to refer to for relace and diff stuff.
Important
Adds 'Fast Apply' feature using Relace service for quick code changes with UI and backend integration.
applyWithRelace,applyWithRelaceHorizontal,applyWithRelaceVertical,acceptRelaceDiff, andrejectRelaceDifftoToIdeFromWebviewProtocolinideWebview.ts.VsCodeMessengerto manage code changes and diffs.getFastApplyChangesWithRelaceinrelace.tsto fetch modified content from a server.CodeBlockToolBarinCodeBlockToolbar.tsxfor horizontal and vertical application of changes.extractCodeFromMarkdowntointegrationUtils.tsto extract code from markdown text.RelaceDiffManagerinrelaceDiffManager.tsto manage diff states.SERVER_URLinparameters.tsto use a local development URL.This description was created by
for f70ebd3. It will automatically update as commits are pushed.