[FIX] Tasks update for cross platform compatibility #151
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlwillia6
requested review from
nang-dev,
Fryingpannn and
a team
as code owners
…update-for-cross-platform-compatibility
…update-for-cross-platform-compatibility
|
@Himanshu-Singh-Chauhan Could you test this one on windows? Also @charlwillia6 , aren't we removing part of the path completely here? Would this not make it not be able to find |
@Fryingpannn This works great on Windows. In fact, prepackag'ing wasn't working on Windows at all before. Hence why I made this change. And it works on Linux too. The only one I wasn't sure about was Mac, because I can't test it. The part that mattered was this for the path:
This change is necessary for proper debugging in Windows. |
…update-for-cross-platform-compatibility
…update-for-cross-platform-compatibility
Himanshu-Singh-Chauhan
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description ✏️
When using Git Bash in Windows, running the debugger caused an error for prepackage.js. The issue was because the path had incorrect forward slashes in the path.
Fixes this issue:
This fix makes the prepackaging cross-platform compatible and now it will work in Windows.
Checklist ✅